v0.9.2

[gmpassos]

• New MultiOutput: allow multiple simultaneous outputs.
• New AsyncOutput: performs output in asynchronous mode.
• New LogPlatform: identifies the runtime platform, and it's capabilities.
• New LoggerFactory: A Logger factory with predefined properties.
• ConsoleOutput: now merging multiple lines to one String to avoid multiple IO calls.
• MemoryOutput: overrides [] operator for events buffer access.
• SimplePrinter, PrettyPrinter, PrefixPrinter: added optional name property.
• Logger.log(): try catch while sending events to output,
  to avoid Logger influence over the main software.
• README.md: fixed and improved badges.

[ngoctranfire]

I think this should also solve most of the cases I had presented in #54. This is a great help. I'm curious, but have we thought about consolidating our efforts with lumberdash? I feel like both libraries have a lot of strengths, but this one can really start to build different "clients", kind of how lumberdash has them too:
https://github.com/jorgecoca/lumberdash

[gmpassos]

Yes, I know that I should split this improvements in smaller pull requests. I will try in the future. Best regards, GMP

…

On 18 Jun 2020, at 14:55, Ngoc Buu Tran ***@***.***> wrote:  I think this should also solve most of the cases I had presented in #54. This is a great help. I'm curious, but have we thought about consolidating our efforts with lumberdash? I feel like both libraries have a lot of strengths, but this one can really start to build different "clients", kind of how lumberdash has them too: https://github.com/jorgecoca/lumberdash — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[ngoctranfire]

Do you know what the status of this seems to be right now? I really think this should be updated to push in as soon as possible. @leisim any status updates?

[haarts]

I'll be able to give this some love on Thursday. Work prevented me from looking into this earlier.

[haarts]

First off: thank you so much for your contributions. There's a lot to love in here!

Second, I haven't completely finished the review, the PrettyPrinter I have really looked at. That needs to come later, hopefully tomorrow.

Also I really dig what you have done with the whole platform thing. That was certainly clunky previously. But I do feel a bit uncomfortable with the tight coupling with the ConsoleOutput. But I have not ready answer on how to address that.

Please have a look at the comments I've made so far. We'll work together to get this in!

[haarts]

I think the platform business is close to be good to merge. Some of that code belongs to the ConsoleOutput I think but I feel that is of minor importance.

The named logger thing I agree with too.

The AsyncOutput and LoggerFactory I'm not convinced off. I would rather have those in a separate pull request.

The changes to the MemoryOutput seem redundant and I would rather keep the code base small.

The bug fixes are obviously good.

[gmpassos]

The AsyncOutput and LoggerFactory I'm not convinced off. I would rather have those in a separate pull request.

• AsyncOutput:
  important for applications with high volume of requests, like a backend.

• LoggerFactory:
  I just implemented the basics to have something similar to http://www.slf4j.org/, a very famous logging framework for Java.
  For me this is very important, since I will be able to have different logger configurations depending of the namespace/package and dynamic configurations (like a development mode without change the code).

[haarts]

This pull request has been lingering for some time now. The blame is mine.
I want to suggest the following;

• I see little additional benefit for the AsyncLogger and suggest you keep it in your own code base.
• Same goes with the LoggerFactory. I'm really trying to keep the code base small and with maximum impact.
• I will merge the pull request after these are removed (or I can do that when I merge). After the merge I'll take a couple of hours to the merged code with the remainder of the library. This probably means that not everything is going to work as you originally envisioned!

This is a bit in line with what I said here.

There is a lot of good stuff in the PR and there's also just a lot. I do want to land this valuable contribution!

[gmpassos]

I have made the requested changes

[haarts]

A whole bunch of this stuff just landed on master. What's notably missing is named loggers. I thought that perhaps we could use the PrefixPrinter for that. Keep it nice and composable. The PrettyPrinter is also kept simple as opposed to the suggestion here. The proposed new code lacked test coverage and I was unsure why this functionality would be beneficial to the logger package.

I'm closing this PR and ponder on the named loggers.

[gmpassos]

The main idea of a named logger is to show (when printing) the origin of the log event. In Java usually is the name of the class or a package. Best regards.