Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.9.2 #52
v0.9.2 #52
Changes from 6 commits
93f01ba
8234712
72ca11d
b3861c2
ded4e87
bb7042a
56e969b
627a5fc
0b48b36
e309b0f
582cf85
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle I really like this. Logging actions should never block the main app.
But I wonder if the same functionality could be achieved with the existing StreamOutput (I'm not sure this compiles):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since Dart doesn't have
yeld
andsleep
, any code in the thread will run straightforward (specially in the browser). The concept to release CPU of the current thread doesn't exists for Dart. If you use a Stream, doesn't mean that it willyeld
and release CPU for the main software, or really parallelize anything . Also streams won't control priority of events.This is why
AsyncOutput
has_maximumFlushTime
. If methodflush
takes more than_maximumFlushTime
ms, it stops flushing and schedules a call to flush some ms later, mimicking ayeld
behaviour of the thread.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dart does have a
yield
keyword. With which you can give control back and the scheduler can schedule a different micro task (or not).I think it would be a good idea to deal with this contribution in a different pull request. Can you open a new PR for this particular output?