Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Provided Update-Script don't work with Pi.Alert LXC #281

Closed
katomic opened this issue Mar 22, 2024 · 3 comments
Closed

[Bug] Provided Update-Script don't work with Pi.Alert LXC #281

katomic opened this issue Mar 22, 2024 · 3 comments
Labels
Bug Something isn't working

Comments

@katomic
Copy link

katomic commented Mar 22, 2024

System Information
Architecture is proxmox container (amd64)
Pi.Alert version: 2024 Puche & leiweibau (2024-02-24)

Describe the bug
running the update command
bash -c "$(wget -qLO - https://github.com/leiweibau/Pi.Alert/raw/main/install/pialert_update.sh)"
in the container's console results in this error:

Pi.Alert directory dosn't exists: /root/pialert

Viewing logfile:

root@pialert:~# cat pialert_update_2024-03-22_10-13.log

############################################################################

You are planning to update Pi.Alert. Please make sure that no scan takes

place during the update to avoid possible database errors afterwards!!!

This can be done by pausing the Arp scan via the settings page. However,

scans that are already running will not be terminated. For more

information, check the Help/FAQ section in Pi.Alert

############################################################################

############################################################
Pi.Alert Update
############################################################
Fri Mar 22 10:13:04 SAST 2024
Logfile: pialert_update_2024-03-22_10-13.log



** ERROR UPDATING PI.ALERT **



Pi.Alert directory dosn't exists: /root/pialert

Use 'cat pialert_update_2024-03-22_10-13.log' to view update log

root@pialert:~#

@katomic katomic added the Bug Something isn't working label Mar 22, 2024
@leiweibau
Copy link
Owner

leiweibau commented Mar 22, 2024

At first:
I would have expected at least a short description of the error in the title to make it a little easier for me as the maintainer. But thank you for drawing my attention to the misunderstanding in the template. I will probably have to invest some more work here.

Now to the actual problem:
If you use the LXC version, you must also use the update script that @tteck offers.

To create a new Proxmox VE Pi.Alert LXC, run the command below in the Proxmox VE Shell.
To Update Pi.Alert, run the command below (or type update) in the LXC Console.
bash -c "$(wget -qLO - https://github.com/tteck/Proxmox/raw/main/ct/pialert.sh)"

@leiweibau leiweibau changed the title [Bug] [Bug] Provided Update-Script don't work with Pi.Alert LXC Mar 22, 2024
@katomic
Copy link
Author

katomic commented Mar 22, 2024

At first: I would have expected at least a short description of the error in the title to make it a little easier for me as the maintainer. But thank you for drawing my attention to the misunderstanding in the template. I will probably have to invest some more work here.

Now to the actual problem: If you use the LXC version, you must also use the update script that @tteck offers.

To create a new Proxmox VE Pi.Alert LXC, run the command below in the Proxmox VE Shell.
To Update Pi.Alert, run the command below (or type update) in the LXC Console.
bash -c "$(wget -qLO - https://github.com/tteck/Proxmox/raw/main/ct/pialert.sh)"

Thank you for your prompt reply!
I did not think to see if @tteck had an update script for your branch.
Nice work all the same!

PS, Does your branch support the same network graph that is seen here: https://github.com/jokob-sk/Pi.Alert/blob/main/docs/img/network.png ?

@katomic katomic closed this as completed Mar 22, 2024
@leiweibau
Copy link
Owner

I did not think to see if @tteck had an update script for your branch.

In principle, @tteck also uses my update script, but he uses undocumented switches, which we have defined so that the installation in the LXC container works according to his specifications.

Does your branch support the same network graph that is seen here

No, unfortunately this is not possible. This is due to the different "philosophies" on which this is based.

The representation chosen by @jokob-sk basically shows the hierarchy. This also works quite well in the flow chart and I admit that I also like it.

However, I would like to show the port assignments. Here it can also be that a switch is connected 2x to the same router, then 2x to another switch. This 2nd switch is also connected 2x to the router and a 2nd router. This makes it difficult to use a flowchart that only shows one connection (line) at a time. There are also JS libraries that can map something like this, but unfortunately mainly on an API basis (basic or paid) (https://github.com/mermaid-js/mermaid). On my site, the port composition is so convoluted that I'm not even sure if I would implement it if the JS libraries were free/self-hosted.

leiweibau added a commit that referenced this issue Mar 24, 2024
Check for a special installation directory to avoid issues like #283 or #281
leiweibau added a commit that referenced this issue Mar 24, 2024
New:
* CSV download for nmap scan per device
* Insert Nmap scan results to db (only scans with results are saved in the db)
* Add "Delete all nmap scans" Button to maintenance page

Fixed:
* Minor fixes

Updated:
* Readme: add Sponsor
* Language files
* Readme: LINUX-DISTRIBUTIONS.md (Issue Report via mail)
* pialert-cli: to update the database for the new function
* Remove/streamline old code

Changed:
* Update Check: Check for a special installation directory to avoid issues like #283 or #281
* Nmap scan infos moved to faq/help page
* Set timeout for all Nmap scans

Removed:
* Remove nmap session log button from settings page
leiweibau added a commit that referenced this issue Mar 26, 2024
New:
* Add "Delete all nmap scans" Button to maintenance page
* Button to reset the search on the journal page
* CSV download for nmap scan per device
* Insert Nmap scan results to db (only scans with results are saved in the db) (#271)

Fixed:
* Minor fixes and tweaks
* pialert-cli help: When the end of the command list is reached, the command prompt appears again automatically

Updated:
* pialert-cli: to update the database for the new function
* Readme: add Sponsor
* Readme: LINUX-DISTRIBUTIONS.md (Issue Report via mail)
* Cleanup task extended (Nmap scan results)
* Remove/streamline old code
* Language files

Changed:
* Set timeout (60s )for all Nmap scan types
* Update Check: Check for a special installation directory to avoid issues like #283 or #281
* Nmap scan infos moved to faq/help page

Removed:
* Remove Nmap session log button from settings page
leiweibau added a commit that referenced this issue Mar 28, 2024
New:
* Add "Delete all nmap scans" Button to maintenance tab
* Add "Delete all Webservices" Button to maintenance tab
* Button to reset the search on the journal page
* CSV download for nmap scan per device
* Insert Nmap scan results to db (only scans with results are saved in the db) (#271)

Fixed:
* Minor fixes and tweaks
* pialert-cli help: When the end of the command list is reached, the command prompt appears again automatically
* Fixed redirections in the event of an error (reported via mail)

Updated:
* pialert-cli: to update the database for the new function
* Readme: add Sponsor
* Readme: LINUX-DISTRIBUTIONS.md (reported via mail)
* Cleanup task extended (Nmap scan results)
* Remove/streamline old code
* Language files

Changed:
* Set timeout (60s )for all Nmap scan types
* The counter of the currently active scans in the status box (settings page) has been replaced by a simple display (Scans running / No Scans running). Depending on the Linux distribution, the counter varied by +/- 1. The original reason for the introduction of the counter was a ramping up of arp-scan processes, which has not been a problem for many Pi.Alert versions.
* Update Check: Check for a special installation directory to avoid issues like #283 or #281
* Nmap scan infos moved to faq/help page

Removed:
* Remove Nmap session log button from settings page
leiweibau added a commit that referenced this issue Mar 28, 2024
New:
* Add "Delete all nmap scans" Button to maintenance tab
* Add "Delete all Webservices" Button to maintenance tab
* Button to reset the search on the journal page
* CSV download for nmap scan per device
* Insert Nmap scan results to db (only scans with results are saved in the db) (#271)

Fixed:
* Minor fixes and tweaks
* pialert-cli help: When the end of the command list is reached, the command prompt appears again automatically
* Fixed redirections in the event of an error (reported via mail)

Updated:
* pialert-cli: to update the database for the new function
* Readme: add Sponsor
* Readme: LINUX-DISTRIBUTIONS.md (reported via mail)
* Cleanup task extended (Nmap scan results)
* Remove/streamline old code
* Language files

Changed:
* Set timeout (60s )for all Nmap scan types
* The counter of the currently active scans in the status box (settings page) has been replaced by a simple display (Scans running / No Scans running). Depending on the Linux distribution, the counter varied by +/- 1. The original reason for the introduction of the counter was a ramping up of arp-scan processes, which has not been a problem for many Pi.Alert versions.
* Update Check: Check for a special installation directory to avoid issues like #283 or #281
* Nmap scan infos moved to faq/help page

Removed:
* Remove Nmap session log button from settings page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants