Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates #3

Merged
merged 39 commits into from
Jul 3, 2023
Merged

updates #3

merged 39 commits into from
Jul 3, 2023

Conversation

hannesdelbeke
Copy link
Collaborator

@hannesdelbeke hannesdelbeke commented Jun 27, 2023

preview the new README here

README changes

  • tweaked readme so table shows comparison next each other
  • moved a reference to references
  • added pypi shield
  • added pip install instructions
  • tweaked some text and layout

CODE changes:

  • fixed icon bug that assumes icons are in the path, but they might not be icons do not load correctly #2
  • removed qt dependency
  • added a method so package can be easily run with a one liner. no need to manually import qrc resources etc.
import unreal_qt_stylesheet
unreal_qt_stylesheet.setup()

PACKAGING & PYPI release

  • packaged the stylesheet as an importable package, making it pip installable (moved files inside a folder)
  • added pypi release action, and uploaded to pypi. contact me to get pypi access and i will gladly give it to you.
    if PYPI access is transfered to original repo:
    • we need to add a secret to the project for the build action
    • need to update URLs in the package to point to original repo
    • make a release to push the latest update.

If you make me maintainer of the original repo I can do the setup for you, if not I'm happy to instruct you how.

@leixingyu
Copy link
Owner

I wonder if we should keep python 2 support, what do you think?

@hannesdelbeke
Copy link
Collaborator Author

ready for review now

@hannesdelbeke
Copy link
Collaborator Author

Sounds like everything is resolved.
Let me know if you need anything else from me to merge this in


### Modifying the style sheet
```python
Copy link
Owner

@leixingyu leixingyu Jul 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last comment, let's move this code block the installation section as "example", also I expanded it so it's more clear:

import unreal_stylesheet


if __name__ == '__main__':
    app = QtWidgets.QApplication(sys.argv)

    unreal_stylesheet.setup()

    window = TestWindow()
    window.show()
    sys.exit(app.exec_())

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added that to the README, have a look here

import unreal_stylesheet

if __name__ == '__main__':
    app = QtWidgets.QApplication(sys.argv)

    # style your QApp, requires a QApplication instance
    unreal_stylesheet.setup()  # <== Just 1 line of code to make the magic happen

    # create & show your Qt widget
    window = TestWindow()
    window.show()
    sys.exit(app.exec_())                   

@leixingyu
Copy link
Owner

looks good! thanks for contributing

@leixingyu leixingyu merged commit f37c456 into leixingyu:master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants