-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates #3
updates #3
Conversation
I wonder if we should keep python 2 support, what do you think? |
MAJOR bump, incompatible API changes
wasnt able to test this since there is no version build for my py version, since it's so old
ready for review now |
Sounds like everything is resolved. |
|
||
### Modifying the style sheet | ||
```python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one last comment, let's move this code block the installation section as "example", also I expanded it so it's more clear:
import unreal_stylesheet
if __name__ == '__main__':
app = QtWidgets.QApplication(sys.argv)
unreal_stylesheet.setup()
window = TestWindow()
window.show()
sys.exit(app.exec_())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added that to the README, have a look here
import unreal_stylesheet
if __name__ == '__main__':
app = QtWidgets.QApplication(sys.argv)
# style your QApp, requires a QApplication instance
unreal_stylesheet.setup() # <== Just 1 line of code to make the magic happen
# create & show your Qt widget
window = TestWindow()
window.show()
sys.exit(app.exec_())
looks good! thanks for contributing |
preview the new README here
README changes
CODE changes:
PACKAGING & PYPI release
if PYPI access is transfered to original repo:
If you make me maintainer of the original repo I can do the setup for you, if not I'm happy to instruct you how.