Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #388 Triggering Authenticator double encodes body in POST, PUT, PATCH #390

Merged
merged 6 commits into from
Dec 11, 2022
Merged

Fix #388 Triggering Authenticator double encodes body in POST, PUT, PATCH #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9df4ed1
:white_check_mark: Add authenticator tests
techouse Dec 10, 2022
5a36d27
:white_check_mark: Add authenticator tests
techouse Dec 10, 2022
bc0e50c
:white_check_mark: Add authenticator tests
techouse Dec 10, 2022
4169b1b
:white_check_mark: Add authenticator tests
techouse Dec 10, 2022
80cc808
:white_check_mark: Add authenticator tests
techouse Dec 10, 2022
e0f94a6
:bug: #388 Authenticator double encodes body
techouse Dec 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 7 additions & 2 deletions chopper/lib/src/base.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,9 +293,10 @@ class ChopperClient {
ConvertRequest? requestConverter,
ConvertResponse? responseConverter,
}) async {
var req = await _interceptRequest(
final Request req = await _interceptRequest(
await _handleRequestConverter(request, requestConverter),
);

_requestController.add(req);

final streamRes = await httpClient.send(await req.toBaseRequest());
Expand All @@ -307,7 +308,11 @@ class ChopperClient {
dynamic res = Response(response, response.body);

if (authenticator != null) {
var updatedRequest = await authenticator!.authenticate(req, res, request);
final Request? updatedRequest = await authenticator!.authenticate(
request,
res,
request,
);

if (updatedRequest != null) {
res = await send<BodyType, InnerType>(
Expand Down