Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding follow redirects to toHttpRequest #430

Merged
merged 2 commits into from May 26, 2023

Conversation

Joran-Dob
Copy link
Contributor

Currently followRedirects are not passed to http.Request in this method toHttpRequest. This causes setting followRedirects to false for example in a interceptor to not be passed http client.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #430 (b927cce) into develop (08781c9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #430      +/-   ##
===========================================
+ Coverage    93.63%   93.65%   +0.01%     
===========================================
  Files            8        8              
  Lines          440      441       +1     
===========================================
+ Hits           412      413       +1     
  Misses          28       28              
Impacted Files Coverage Δ
chopper/lib/src/request.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@techouse techouse self-assigned this May 26, 2023
@techouse techouse added the bug Something isn't working label May 26, 2023
@techouse techouse merged commit 485ef8f into lejard-h:develop May 26, 2023
7 checks passed
@Joran-Dob Joran-Dob deleted the bugfix/adding-follow-redirects branch May 26, 2023 09:23
@techouse
Copy link
Collaborator

Thanx!

@Joran-Dob
Copy link
Contributor Author

Thanx!

Thanks for the great package, small question. Any idea when this change will be in a release? 😄

@techouse
Copy link
Collaborator

techouse commented May 26, 2023

Any idea when this change will be in a release? 😄

Soon, I hope 😅

Waiting for #431 and #432 to get approved & merged. Then I'll make a release. 😇

@techouse techouse mentioned this pull request May 28, 2023
techouse added a commit that referenced this pull request May 28, 2023
# chopper

## 6.1.3

* Add follow redirects to toHttpRequest (#430)
* Update http constraint to ">=0.13.0 <2.0.0" (#431)
* Add MultipartRequest log to CurlInterceptor (#435)

---

# chopper_built_value

## 1.2.2

* Update http constraint to ">=0.13.0 <2.0.0" (#431)

---

# example

* Update squadron example (#432)

---

# Github actions

* Add cleanup step to publish workflow (#434)

---------

Co-authored-by: Joran Dob <joran998@gmail.com>
Co-authored-by: Joseph, NamKung <nkw0608@gmail.com>
Co-authored-by: Klemen Tusar <techouse@gmail.com>
@techouse
Copy link
Collaborator

techouse commented May 30, 2023

Any idea when this change will be in a release? 😄

@Joran-Dob the change was released 2 days ago in v6.1.3 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants