Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Attach request/response to interceptor log lines #475

Merged
merged 2 commits into from Aug 10, 2023
Merged

✨ Attach request/response to interceptor log lines #475

merged 2 commits into from Aug 10, 2023

Conversation

Maxr1998
Copy link
Contributor

@Maxr1998 Maxr1998 commented Aug 9, 2023

As discussed in #470.

@codecov
Copy link

codecov bot commented Aug 9, 2023 •
edited

Codecov Report

Merging #475 (ccdbf2d) into develop (0af17f8) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #475      +/-   ##
===========================================
+ Coverage    93.72%   93.83%   +0.11%     
===========================================
  Files            8        9       +1     
  Lines          446      454       +8     
===========================================
+ Hits           418      426       +8     
  Misses          28       28
Files Changed Coverage Δ
chopper/lib/src/chopper_log_record.dart 100.00% <100.00%> (ø)
chopper/lib/src/http_logging_interceptor.dart 96.36% <100.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@techouse techouse self-assigned this Aug 9, 2023
@techouse techouse added the enhancement New feature or request label Aug 9, 2023
@techouse
Copy link
Collaborator

techouse commented Aug 9, 2023

LGTM

@Guldem & @JEuler any remarks?

JEuler
JEuler approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@JEuler JEuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JEuler JEuler merged commit 1a01b60 into lejard-h:develop Aug 10, 2023
6 checks passed
@Maxr1998 Maxr1998 deleted the log-record branch August 10, 2023 07:32
@Maxr1998
Copy link
Contributor Author

Thank you!

@Guldem
Copy link
Contributor

Guldem commented Aug 10, 2023

Thank you!

Thanks for adding the log records.

@techouse
Copy link
Collaborator

I'll make a release with this feature later today or tomorrow.

@JEuler
Copy link
Collaborator

JEuler commented Aug 10, 2023

@techouse @Maxr1998 Thank you so much!

@techouse techouse mentioned this pull request Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JEuler JEuler JEuler approved these changes

@techouse techouse techouse approved these changes

@lejard-h lejard-h Awaiting requested review from lejard-h lejard-h is a code owner

@meysam1717 meysam1717 Awaiting requested review from meysam1717 meysam1717 is a code owner

@stewemetal stewemetal Awaiting requested review from stewemetal stewemetal is a code owner

Assignees

@techouse techouse

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Maxr1998 @techouse @Guldem @JEuler