Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ encode DateTime query parameters as ISO8601 #516

Merged
merged 1 commit into from Oct 11, 2023
Merged

✨ encode DateTime query parameters as ISO8601 #516

merged 1 commit into from Oct 11, 2023

Conversation

techouse
Copy link
Collaborator

Addresses #515

@techouse techouse added bug Something isn't working enhancement New feature or request labels Oct 10, 2023
@techouse techouse mentioned this pull request Oct 10, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited

Codecov Report

Merging #516 (8ce5436) into develop (fedb899) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #516      +/-   ##
===========================================
+ Coverage    93.91%   93.95%   +0.03%     
===========================================
  Files            9        9              
  Lines          460      463       +3     
===========================================
+ Hits           432      435       +3     
  Misses          28       28
Files Coverage Δ
chopper/lib/src/utils.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

JEuler
JEuler approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@JEuler JEuler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@techouse techouse merged commit 52133f6 into lejard-h:develop Oct 11, 2023
6 checks passed
@techouse techouse deleted the feat/515-dateTime-ISO8601 branch October 11, 2023 06:03
techouse added a commit that referenced this pull request Oct 11, 2023
@techouse
# chopper
f3466ee 
## 7.0.8

- #516
@techouse techouse mentioned this pull request Oct 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JEuler JEuler JEuler approved these changes

@lejard-h lejard-h Awaiting requested review from lejard-h lejard-h is a code owner

@meysam1717 meysam1717 Awaiting requested review from meysam1717 meysam1717 is a code owner

@stewemetal stewemetal Awaiting requested review from stewemetal stewemetal is a code owner

Assignees

@JEuler JEuler

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@techouse @JEuler