Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add Target annotations #567

Merged

Conversation

Guldem
Copy link
Contributor

@Guldem Guldem commented Jan 25, 2024

Added Target annotations to chopper annotations to provide analysers and tooling with more information about the annotation placements.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (168982f) 94.17% compared to head (f23a58e) 94.17%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #567   +/-   ##
========================================
  Coverage    94.17%   94.17%           
========================================
  Files           11       11           
  Lines          481      481           
========================================
  Hits           453      453           
  Misses          28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@techouse
Copy link
Collaborator

I'm not familiar with this feature. What does it do exactly?

@Guldem
Copy link
Contributor Author

Guldem commented Jan 25, 2024

The dart analyzer can use the provided context to determine if the annotation placement is correct. For example placing the @Body() annotation on a class instead of a method parameter will result in a lint invalid_annotation_target warning.

image
image

@techouse
Copy link
Collaborator

Cool! LGTM!

@techouse techouse merged commit be1c370 into lejard-h:develop Jan 25, 2024
6 checks passed
techouse added a commit that referenced this pull request Jan 28, 2024
# chopper

## 7.1.1

- #567
techouse added a commit that referenced this pull request Jan 28, 2024
* 🔖 release chopper v7.1.1

# chopper

## 7.1.1

- #567

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Job Guldemeester <job@dutchcodingcompany.com>
@Guldem Guldem deleted the feature/add_meta_data_for_annotations branch April 6, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants