Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Export ChopperHttpException #570

Merged
merged 1 commit into from Jan 31, 2024

Conversation

Guldem
Copy link
Contributor

@Guldem Guldem commented Jan 31, 2024

chopper_http_exception.dart wasn't included in library export. Which makes it hard to catch in try catch statements because importing is harder.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63e6d00) 94.17% compared to head (8a06ee1) 94.17%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #570   +/-   ##
========================================
  Coverage    94.17%   94.17%           
========================================
  Files           11       11           
  Lines          481      481           
========================================
  Hits           453      453           
  Misses          28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@techouse techouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@techouse techouse merged commit 5585ffb into lejard-h:develop Jan 31, 2024
6 checks passed
techouse added a commit that referenced this pull request Feb 25, 2024
# chopper

## 7.1.1+1

- #570
techouse added a commit that referenced this pull request Feb 26, 2024
* 🔖 release chopper v7.1.1+1

# chopper

## 7.1.1+1

- #570

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Job Guldemeester <job@dutchcodingcompany.com>
@Guldem Guldem deleted the fix/export_chopper_http_exception branch April 6, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants