ladislas+hugo/feature/quit activity mode #1062

ladislas · 2022-10-13T12:16:38Z

Validated on robot

github-actions · 2022-10-13T12:29:22Z

File comparision analysis report

🔖 Info

base: develop / 0bad39d + mbed-os-6.15.1+fixes + -std=c++20
head: ladislas+hugo/feature/quit-activity-mode / 0bad39d + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	169636 (64%)	92508 (35%)	30920 (5%)
os	410936 (26%)	1153736 (73%)	79608 (15%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	407848 (19%) 410936 (19%)	📈 3088 (0%)	79224 (15%) 79608 (15%)	📈 384 (0%)
bootloader	✔️	✅	✅	169636 (8%)	ø	30920 (5%)	ø
spike_lk_audio	✔️	✅	✅	125076 (5%)	ø	14568 (2%)	ø
spike_lk_behavior_kit	✔️	✅	✅	189752 (9%)	ø	48120 (9%)	ø
spike_lk_ble	✔️	✅	✅	228768 (10%)	ø	28200 (5%)	ø
spike_lk_bluetooth	✔️	✅	✅	82948 (3%)	ø	11544 (2%)	ø
spike_lk_boost_ut	✔️	✅	✅	355600 (16%)	ø	18000 (3%)	ø
spike_lk_cg_animations	✔️	✅	✅	144632 (6%)	ø	46528 (8%)	ø
spike_lk_color_kit	✔️	✅	✅	65712 (3%)	ø	13744 (2%)	ø
spike_lk_command_kit	✔️	✅	✅	192520 (9%)	ø	50944 (9%)	ø
spike_lk_config_kit	✔️	✅	✅	126956 (6%)	ø	14312 (2%)	ø
spike_lk_coreled	✔️	✅	✅	76164 (3%)	ø	13688 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	74736 (3%)	ø	12072 (2%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	139016 (6%)	ø	14416 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	327112 (15%)	ø	27576 (5%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_fs	✔️	✅	✅	174616 (8%)	ø	47888 (9%)	ø
spike_lk_lcd	✔️	✅	✅	162236 (7%)	ø	46616 (8%)	ø
spike_lk_led_kit	✔️	✅	✅	103992 (4%)	ø	14608 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	63736 (3%)	ø	12256 (2%)	ø
spike_lk_motors	✔️	✅	✅	62600 (2%)	ø	11488 (2%)	ø
spike_lk_qdac	✔️	✅	✅	78564 (3%)	ø	11816 (2%)	ø
spike_lk_reinforcer	✔️	✅	✅	103480 (4%)	ø	14608 (2%)	ø
spike_lk_rfid	✔️	✅	✅	80920 (3%)	ø	11520 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	78196 (3%)	ø	12568 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	67048 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_serial_number	✔️	✅	✅	114244 (5%)	ø	14056 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	126236 (6%)	ø	15304 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	82032 (3%)	ø	13288 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-10-24 11:39:19.731531744 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-10-24 11:39:20.151534085 +0000
@@ -1,48 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       620(+620) |     18(+18) |     199(+199) |
+| [fill]                     |       664(+664) |     18(+18) |     208(+208) |
 | [lib]/ActivityKit.a        |   19586(+19586) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1368(+1368) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1794(+1794) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7944(+7944) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1432(+1432) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       750(+750) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1074(+1074) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1484(+1484) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       774(+774) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   49944(+49944) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 173212(+173212) |   773(+773) | 19647(+19647) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10684(+10684) |     16(+16) |     204(+204) |
-| main.cpp.obj               |   59680(+59680) |   548(+548) | 23751(+23751) |
-| Subtotals                  | 365796(+365796) | 3944(+3944) | 74912(+74912) |
-Total Static RAM memory (data + bss): 78856(+78856) bytes
-Total Flash memory (text + data): 369740(+369740) bytes
+| main.cpp.obj               |   62580(+62580) |   548(+548) | 24126(+24126) |
+| Subtotals                  | 368740(+368740) | 3944(+3944) | 75296(+75296) |
+Total Static RAM memory (data + bss): 79240(+79240) bytes
+Total Flash memory (text + data): 372684(+372684) bytes

Flash used: 410936&nbsp;(19%) / total: 2097152
SRAM used: 79608&nbsp;(15%) / total: 524288

github-actions · 2022-10-13T12:29:38Z

File comparision analysis report

🔖 Info

base: develop / 0bad39d + mbed-os-6.15.1+fixes + -std=c++20
head: ladislas+hugo/feature/quit-activity-mode / 0bad39d + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	182012 (69%)	80132 (30%)	37456 (7%)
os	451908 (28%)	1112764 (71%)	86664 (16%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	446020 (21%) 451908 (21%)	📈 5888 (1%)	86280 (16%) 86664 (16%)	📈 384 (0%)
bootloader	✔️	✅	✅	182012 (8%)	ø	37456 (7%)	ø
spike_lk_audio	✔️	✅	✅	135068 (6%)	ø	20984 (4%)	ø
spike_lk_behavior_kit	✔️	✅	✅	198252 (9%)	ø	54536 (10%)	ø
spike_lk_ble	✔️	✅	✅	236652 (11%)	ø	34856 (6%)	ø
spike_lk_bluetooth	✔️	✅	✅	92236 (4%)	ø	18064 (3%)	ø
spike_lk_boost_ut	✔️	✅	✅	367784 (17%)	ø	24672 (4%)	ø
spike_lk_cg_animations	✔️	✅	✅	152264 (7%)	ø	53064 (10%)	ø
spike_lk_color_kit	✔️	✅	✅	88352 (4%)	ø	20216 (3%)	ø
spike_lk_command_kit	✔️	✅	✅	202716 (9%)	ø	57872 (11%)	ø
spike_lk_config_kit	✔️	✅	✅	138868 (6%)	ø	20976 (4%)	ø
spike_lk_coreled	✔️	✅	✅	87916 (4%)	ø	20104 (3%)	ø
spike_lk_event_queue	✔️	✅	✅	84088 (4%)	ø	18744 (3%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	153984 (7%)	ø	21336 (4%)	ø
spike_lk_file_reception	✔️	✅	✅	331180 (15%)	ø	34072 (6%)	ø
spike_lk_flash_memory	✔️	✅	✅	86712 (4%)	ø	18056 (3%)	ø
spike_lk_fs	✔️	✅	✅	173976 (8%)	ø	47976 (9%)	ø
spike_lk_lcd	✔️	✅	✅	171852 (8%)	ø	53288 (10%)	ø
spike_lk_led_kit	✔️	✅	✅	115708 (5%)	ø	21024 (4%)	ø
spike_lk_log_kit	✔️	✅	✅	84440 (4%)	ø	19248 (3%)	ø
spike_lk_motors	✔️	✅	✅	86008 (4%)	ø	18088 (3%)	ø
spike_lk_qdac	✔️	✅	✅	91508 (4%)	ø	18616 (3%)	ø
spike_lk_reinforcer	✔️	✅	✅	112188 (5%)	ø	21024 (4%)	ø
spike_lk_rfid	✔️	✅	✅	84700 (4%)	ø	18024 (3%)	ø
spike_lk_sensors_battery	✔️	✅	✅	87056 (4%)	ø	19120 (3%)	ø
spike_lk_sensors_light	✔️	✅	✅	83944 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	84696 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90336 (4%)	ø	18032 (3%)	ø
spike_lk_sensors_touch	✔️	✅	✅	91608 (4%)	ø	18296 (3%)	ø
spike_lk_serial_number	✔️	✅	✅	136188 (6%)	ø	20896 (3%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	82584 (3%)	ø	18072 (3%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	148044 (7%)	ø	21912 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100328 (4%)	ø	19080 (3%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	87940 (4%)	ø	19960 (3%)	ø
spike_lk_wifi	✔️	✅	✅	130640 (6%)	ø	21368 (4%)	ø
spike_mbed_blinky	✔️	✅	✅	57616 (2%)	ø	11496 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84112 (4%)	ø	18920 (3%)	ø
spike_stl_cxxsupport	✔️	✅	✅	83424 (3%)	ø	18144 (3%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-10-24 11:38:00.695557201 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-10-24 11:38:01.067562013 +0000
@@ -1,48 +1,48 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       638(+638) |     18(+18) |     220(+220) |
+| [fill]                     |       658(+658) |     18(+18) |     229(+229) |
 | [lib]/ActivityKit.a        |   19586(+19586) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1368(+1368) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1794(+1794) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         62(+62) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7944(+7944) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1432(+1432) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       750(+750) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1074(+1074) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1484(+1484) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       588(+588) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       774(+774) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   48840(+48840) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 174464(+174464) |   773(+773) | 19735(+19735) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10732(+10732) |     16(+16) |     204(+204) |
-| main.cpp.obj               |   97162(+97162) |   548(+548) | 30698(+30698) |
-| Subtotals                  | 403492(+403492) | 3944(+3944) | 81968(+81968) |
-Total Static RAM memory (data + bss): 85912(+85912) bytes
-Total Flash memory (text + data): 407436(+407436) bytes
+| main.cpp.obj               | 102902(+102902) |   548(+548) | 31073(+31073) |
+| Subtotals                  | 409252(+409252) | 3944(+3944) | 82352(+82352) |
+Total Static RAM memory (data + bss): 86296(+86296) bytes
+Total Flash memory (text + data): 413196(+413196) bytes

Flash used: 451908&nbsp;(21%) / total: 2097152
SRAM used: 86664&nbsp;(16%) / total: 524288

codecov · 2022-10-14T13:53:40Z

Codecov Report

Merging #1062 (5c1c527) into hugo/feature/Add-operator-+=-to-kernel-stub (faf8d70) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 5c1c527 differs from pull request most recent head 6266ca8. Consider uploading reports for the commit 6266ca8 to get more accurate results

@@                               Coverage Diff                               @@
##           hugo/feature/Add-operator-+=-to-kernel-stub    #1062      +/-   ##
===============================================================================
+ Coverage                                        96.00%   96.05%   +0.04%     
===============================================================================
  Files                                              133      133              
  Lines                                             3178     3190      +12     
===============================================================================
+ Hits                                              3051     3064      +13     
+ Misses                                             127      126       -1

Impacted Files	Coverage Δ
libs/RobotKit/include/RobotController.h	`94.39% <100.00%> (+0.76%)`	⬆️
libs/RobotKit/include/StateMachine.h	`100.00% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ladislas

LGTM 👍
I made a suggestion regarding the conditions to make the workflow clearer.

libs/RobotKit/include/RobotController.h

YannLocatelli

Validated on the robot

A case is not covered or all cases are not clearly specified.

Some question about tests

libs/RobotKit/include/StateMachine.h

libs/RobotKit/tests/RobotController_test_stateIdle.cpp

libs/RobotKit/tests/RobotController_test_stateAutonomousActivities.cpp

libs/RobotKit/tests/RobotController_test_stateWorking.cpp

libs/RobotKit/tests/RobotController_test_stateAutonomousActivities.cpp

libs/RobotKit/include/RobotController.h

YannLocatelli

Partially validated on robot: Idle/Working ↔ Autonomous Activities (Activity not playing)

Some suggestions

Some code is not covered according to sonarcloud, but no clue on how to reach them considering preceding conditions

libs/RobotKit/include/RobotController.h

libs/RobotKit/tests/RobotController_test_stateWorking.cpp

libs/RobotKit/tests/RobotController_test_stateAutonomousActivities.cpp

libs/RobotKit/tests/RobotController_test_stateWorking.cpp

libs/RobotKit/tests/RobotController_test_stateAutonomousActivities.cpp

ladislas

LGTM 👍

YannLocatelli · 2022-10-24T10:01:53Z

Linked to

hugo/feature/Use Dice roll to go back to Idle #1058

sonarcloud · 2022-10-24T11:42:03Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

97.1% Coverage
0.0% Duplication

ladislas self-assigned this Oct 13, 2022

ladislas added the 01 - type: task Something to do label Oct 13, 2022

ladislas added this to the Future Release milestone Oct 13, 2022

HPezz force-pushed the ladislas+hugo/feature/quit-activity-mode branch from 7b36dc1 to e6076a8 Compare October 14, 2022 13:41

HPezz force-pushed the ladislas+hugo/feature/quit-activity-mode branch 4 times, most recently from 1e6cee9 to df54d6a Compare October 20, 2022 09:11

HPezz requested a review from YannLocatelli October 20, 2022 09:35

HPezz self-assigned this Oct 20, 2022

ladislas commented Oct 20, 2022

View reviewed changes

libs/RobotKit/include/RobotController.h Outdated Show resolved Hide resolved

YannLocatelli requested changes Oct 20, 2022

View reviewed changes

HPezz force-pushed the ladislas+hugo/feature/quit-activity-mode branch 4 times, most recently from dec0bb6 to a587177 Compare October 21, 2022 13:30

YannLocatelli reviewed Oct 21, 2022

View reviewed changes

HPezz force-pushed the ladislas+hugo/feature/quit-activity-mode branch from a587177 to 9de637f Compare October 24, 2022 09:01

ladislas commented Oct 24, 2022

View reviewed changes

YannLocatelli approved these changes Oct 24, 2022

View reviewed changes

HPezz changed the base branch from develop to hugo/feature/Add-operator-+=-to-kernel-stub October 24, 2022 10:14

HPezz force-pushed the ladislas+hugo/feature/quit-activity-mode branch from 9de637f to 6266ca8 Compare October 24, 2022 10:15

ladislas force-pushed the hugo/feature/Add-operator-+=-to-kernel-stub branch 2 times, most recently from 52bcc6d to f34e582 Compare October 24, 2022 10:53

Base automatically changed from hugo/feature/Add-operator-+=-to-kernel-stub to develop October 24, 2022 10:54

✨ (RobotKit): Use dice roll to exit autonomous mode

a40c6ad

ladislas force-pushed the ladislas+hugo/feature/quit-activity-mode branch from 6266ca8 to a40c6ad Compare October 24, 2022 11:31

ladislas merged commit fe7cf0b into develop Oct 24, 2022

ladislas deleted the ladislas+hugo/feature/quit-activity-mode branch October 24, 2022 11:32

YannLocatelli mentioned this pull request Oct 25, 2022

hugo/feature/Use Dice roll to go back to Idle #1058

Closed

ladislas linked an issue Nov 1, 2022 that may be closed by this pull request

AutonomousActivity - Using Dice Roll in Main Menu go back to Idle #1056

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ladislas+hugo/feature/quit activity mode #1062

ladislas+hugo/feature/quit activity mode #1062

ladislas commented Oct 13, 2022 •

edited by HPezz

Loading

github-actions bot commented Oct 13, 2022 •

edited

Loading

github-actions bot commented Oct 13, 2022 •

edited

Loading

codecov bot commented Oct 14, 2022 •

edited

Loading

ladislas left a comment

YannLocatelli left a comment •

edited by HPezz

Loading

YannLocatelli left a comment •

edited

Loading

ladislas left a comment

YannLocatelli commented Oct 24, 2022

sonarcloud bot commented Oct 24, 2022

ladislas+hugo/feature/quit activity mode #1062

ladislas+hugo/feature/quit activity mode #1062

Conversation

ladislas commented Oct 13, 2022 • edited by HPezz Loading

github-actions bot commented Oct 13, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Oct 13, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

codecov bot commented Oct 14, 2022 • edited Loading

Codecov Report

ladislas left a comment

Choose a reason for hiding this comment

YannLocatelli left a comment • edited by HPezz Loading

Choose a reason for hiding this comment

YannLocatelli left a comment • edited Loading

Choose a reason for hiding this comment

ladislas left a comment

Choose a reason for hiding this comment

YannLocatelli commented Oct 24, 2022

sonarcloud bot commented Oct 24, 2022

ladislas commented Oct 13, 2022 •

edited by HPezz

Loading

github-actions bot commented Oct 13, 2022 •

edited

Loading

github-actions bot commented Oct 13, 2022 •

edited

Loading

codecov bot commented Oct 14, 2022 •

edited

Loading

YannLocatelli left a comment •

edited by HPezz

Loading

YannLocatelli left a comment •

edited

Loading