functional tests - override runner for better output #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1091 +/- ##
===========================================
+ Coverage 96.02% 96.04% +0.01%
===========================================
Files 138 133 -5
Lines 3248 3183 -65
===========================================
- Hits 3119 3057 -62
+ Misses 129 126 -3 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
ladislas
force-pushed
the
mmyster/feature/udl-synthax
branch
from
243b756
to
ed0b9db
Compare
ladislas
changed the title
ladislas
force-pushed
the
mmyster/feature/udl-synthax
branch
from
ed0b9db
to
015324c
Compare
ladislas
changed the base branch from
develop
to
ladislas/feature/log-kit-log-free
ladislas
force-pushed
the
ladislas/feature/log-kit-log-free
branch
from
56c6c0e
to
59e881a
Compare
ladislas
force-pushed
the
mmyster/feature/udl-synthax
branch
from
015324c
to
4f4dc2b
Compare
HPezz
approved these changes
Nov 14, 2022
Comment on lines
22
to
23
| }; | ||
|
|
There was a problem hiding this comment.
Just an extra reminder here to remove this commit before merging
Base automatically changed from
ladislas/feature/log-kit-log-free
to
develop
November 14, 2022 23:16
ladislas
force-pushed
the
mmyster/feature/udl-synthax
branch
from
4f4dc2b
to
8f37713
Compare
YannLocatelli
requested changes
Nov 17, 2022
Comment on lines
33
to
45
| auto on(ut::events::test_end test_end) -> void | ||
| { | ||
| if (asserts_.fail > fails_) { | ||
| ++tests_.fail; | ||
| printer_ << '\n'; | ||
| printer_ << "Running \"" << test_end.name << "\"..."; | ||
| printer_ << printer_.colors().fail << "FAILED" << printer_.colors().none << '\n'; | ||
| } else { | ||
| ++tests_.pass; | ||
| printer_ << '\n'; | ||
| printer_ << "Running \"" << test_end.name << "\"..."; | ||
| printer_ << printer_.colors().pass << "PASSED" << printer_.colors().none << '\n'; | ||
| } | ||
| } |
There was a problem hiding this comment.
The test is ended, it is not running anymore. Moreover previous format is different since it is on one line.
I suggest two things:
- Do as default implementation by putting at the end
FAILEDorPASSED - As unit test rendering, replace Running by
OK/FAILEDorResult of
There was a problem hiding this comment.
Suggested change
| auto on(ut::events::test_end test_end) -> void | |
| { | |
| if (asserts_.fail > fails_) { | |
| ++tests_.fail; | |
| printer_ << '\n'; | |
| printer_ << "Running \"" << test_end.name << "\"..."; | |
| printer_ << printer_.colors().fail << "FAILED" << printer_.colors().none << '\n'; | |
| } else { | |
| ++tests_.pass; | |
| printer_ << '\n'; | |
| printer_ << "Running \"" << test_end.name << "\"..."; | |
| printer_ << printer_.colors().pass << "PASSED" << printer_.colors().none << '\n'; | |
| } | |
| } | |
| auto on(ut::events::test_end test_end) -> void | |
| { | |
| if (asserts_.fail > fails_) { | |
| ++tests_.fail; | |
| printer_ << printer_.colors().fail << "FAILED" << printer_.colors().none << '\n'; | |
| } else { | |
| ++tests_.pass; | |
| printer_ << printer_.colors().pass << "PASSED" << printer_.colors().none << '\n'; | |
| } | |
| } |
There was a problem hiding this comment.
Suggested change
| auto on(ut::events::test_end test_end) -> void | |
| { | |
| if (asserts_.fail > fails_) { | |
| ++tests_.fail; | |
| printer_ << '\n'; | |
| printer_ << "Running \"" << test_end.name << "\"..."; | |
| printer_ << printer_.colors().fail << "FAILED" << printer_.colors().none << '\n'; | |
| } else { | |
| ++tests_.pass; | |
| printer_ << '\n'; | |
| printer_ << "Running \"" << test_end.name << "\"..."; | |
| printer_ << printer_.colors().pass << "PASSED" << printer_.colors().none << '\n'; | |
| } | |
| } | |
| auto on(ut::events::test_end test_end) -> void | |
| { | |
| if (asserts_.fail > fails_) { | |
| ++tests_.fail; | |
| printer_ << '\n'; | |
| printer_ << "Result of \"" << test_end.name << "\"..."; | |
| printer_ << printer_.colors().fail << "FAILED" << printer_.colors().none << '\n'; | |
| } else { | |
| ++tests_.pass; | |
| printer_ << '\n'; | |
| printer_ << "Result of \"" << test_end.name << "\"..."; | |
| printer_ << printer_.colors().pass << "PASSED" << printer_.colors().none << '\n'; | |
| } | |
| } |
Example of unit test:
ladislas
force-pushed
the
mmyster/feature/udl-synthax
branch
from
8f37713
to
6fac88d
Compare
ladislas
force-pushed
the
mmyster/feature/udl-synthax
branch
from
6fac88d
to
fa2b6d4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.