Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (ble): Add os version in advertising data #1186

Merged
merged 1 commit into from
Dec 9, 2022
Merged

✨ (ble): Add os version in advertising data #1186

merged 1 commit into from
Dec 9, 2022

Conversation

YannLocatelli
Copy link
Member

@YannLocatelli YannLocatelli commented Dec 6, 2022 •
edited
Loading

To be visible without connection, it will avoid to connect to a robot and check its version and go back if it is already updated

@YannLocatelli YannLocatelli added the 01 - type: task Something to do label Dec 6, 2022
@YannLocatelli YannLocatelli added this to the v1.3.0 milestone Dec 6, 2022
@YannLocatelli YannLocatelli self-assigned this Dec 6, 2022
@github-actions
Copy link

github-actions bot commented Dec 6, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 182476 (69%) 79668 (30%) 41624 (7%)
os 472212 (30%) 1092460 (69%) 91920 (17%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ❌ 472084 (22%)
472212 (22%)		 📈
128 (0%)		 91912 (17%)
91920 (17%)		 📈
8 (0%)
bootloader ✔️ ✅ ✅ 182476 (8%) ø 41624 (7%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 409212 (19%) ø 30608 (5%) ø
functional_ut_core_imu ✔️ ✅ ✅ 389196 (18%) ø 30584 (5%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ ✅ ✅ 368140 (17%) ø 30560 (5%) ø
functional_ut_deep_sleep_core_motor ✔️ ✅ ✅ 376076 (17%) ø 30632 (5%) ø
functional_ut_deep_sleep_core_pwm ✔️ ✅ ✅ 378292 (18%) ø 30632 (5%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 365204 (17%) ø 30976 (5%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 366648 (17%) ø 30560 (5%) ø
functional_ut_file_manager ✔️ ✅ ✅ 386420 (18%) ø 30856 (5%) ø
functional_ut_imu_kit ✔️ ✅ ✅ 391388 (18%) ø 30576 (5%) ø
functional_ut_io_expander ✔️ ✅ ✅ 370896 (17%) ø 30576 (5%) ø
functional_ut_qdac ✔️ ✅ ✅ 372064 (17%) ø 30576 (5%) ø
spike_lk_accel_gyro ✔️ ✅ ✅ 94048 (4%) ø 22568 (4%) ø
spike_lk_audio ✔️ ✅ ✅ 135196 (6%) ø 25144 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 198764 (9%) ø 58720 (11%) ø
spike_lk_ble ✔️ ❌ ❌ 237196 (11%)
237260 (11%)		 📈
64 (0%)		 39264 (7%)
39272 (7%)		 📈
8 (0%)
spike_lk_bluetooth ✔️ ✅ ✅ 92364 (4%) ø 22224 (4%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 153608 (7%) ø 57224 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88480 (4%) ø 24376 (4%) ø
spike_lk_command_kit ✔️ ✅ ✅ 203372 (9%) ø 62056 (11%) ø
spike_lk_config_kit ✔️ ✅ ✅ 138932 (6%) ø 25136 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 88044 (4%) ø 24264 (4%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 92884 (4%) ø 22832 (4%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84152 (4%) ø 22904 (4%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 154048 (7%) ø 25496 (4%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331308 (15%) ø 38232 (7%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 86776 (4%) ø 22216 (4%) ø
spike_lk_fs ✔️ ✅ ✅ 174168 (8%) ø 47992 (9%) ø
spike_lk_imu_kit ✔️ ✅ ✅ 97920 (4%) ø 22896 (4%) ø
spike_lk_lcd ✔️ ✅ ✅ 172332 (8%) ø 57464 (10%) ø
spike_lk_led_kit ✔️ ✅ ✅ 115772 (5%) ø 25184 (4%) ø
spike_lk_log_kit ✔️ ✅ ✅ 84776 (4%) ø 23408 (4%) ø
spike_lk_motion_kit ✔️ ✅ ✅ 105640 (5%) ø 24720 (4%) ø
spike_lk_motors ✔️ ✅ ✅ 86336 (4%) ø 22248 (4%) ø
spike_lk_qdac ✔️ ✅ ✅ 91572 (4%) ø 22776 (4%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 112316 (5%) ø 25184 (4%) ø
spike_lk_rfid ✔️ ✅ ✅ 84088 (4%) ø 22184 (4%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 87184 (4%) ø 23280 (4%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 84072 (4%) ø 22216 (4%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 84824 (4%) ø 22216 (4%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90400 (4%) ø 22192 (4%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 91672 (4%) ø 22456 (4%) ø
spike_lk_serial_number ✔️ ✅ ✅ 136316 (6%) ø 25056 (4%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 82712 (3%) ø 22232 (4%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 154980 (7%) ø 26256 (5%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100456 (4%) ø 23240 (4%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 87392 (4%) ø 24120 (4%) ø
spike_lk_wifi ✔️ ✅ ✅ 130832 (6%) ø 25528 (4%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84176 (4%) ø 23080 (4%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 83488 (3%) ø 22304 (4%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-12-08 14:14:16.392536426 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-12-08 14:14:16.764544223 +0000
@@ -1,49 +1,49 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       604(+604) |     18(+18) |     248(+248) |
+| [fill]                     |       640(+640) |     18(+18) |     248(+248) |
 | [lib]/ActivityKit.a        |   19586(+19586) |       0(+0) |         0(+0) |
-| [lib]/BLEKit.a             |     1368(+1368) |       0(+0) |         0(+0) |
+| [lib]/BLEKit.a             |     1436(+1436) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1830(+1830) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         78(+78) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       176(+176) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         60(+60) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       556(+556) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1432(+1432) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       822(+822) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1544(+1544) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       596(+596) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       896(+896) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   48840(+48840) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 174620(+174620) |   773(+773) | 19735(+19735) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10732(+10732) |     16(+16) |     204(+204) |
 | __/__                      |       108(+108) |       0(+0) |         0(+0) |
-| main.cpp.obj               | 121782(+121782) |   548(+548) | 36302(+36302) |
-| Subtotals                  | 428708(+428708) | 3944(+3944) | 87600(+87600) |
-Total Static RAM memory (data + bss): 91544(+91544) bytes
-Total Flash memory (text + data): 432652(+432652) bytes
+| main.cpp.obj               | 121806(+121806) |   548(+548) | 36310(+36310) |
+| Subtotals                  | 428836(+428836) | 3944(+3944) | 87608(+87608) |
+Total Static RAM memory (data + bss): 91552(+91552) bytes
+Total Flash memory (text + data): 432780(+432780) bytes
 
Flash used: 472212 (22%) / total: 2097152
SRAM used: 91920 (17%) / total: 524288
spike_lk_ble (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-12-08 14:14:25.632731036 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-12-08 14:14:25.884736350 +0000
@@ -1,19 +1,19 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       434(+434) |     15(+15) |       82(+82) |
-| [lib]/BLEKit.a          |     1368(+1368) |       0(+0) |         0(+0) |
+| [fill]                  |       410(+410) |     15(+15) |       82(+82) |
+| [lib]/BLEKit.a          |     1436(+1436) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       122(+122) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |     1436(+1436) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   40860(+40860) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 145464(+145464) |   709(+709) | 19447(+19447) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     9940(+9940) |     16(+16) |     204(+204) |
-| main.cpp.obj            |     7508(+7508) |     92(+92) | 15686(+15686) |
-| Subtotals               | 214868(+214868) | 3408(+3408) | 35544(+35544) |
-Total Static RAM memory (data + bss): 38952(+38952) bytes
-Total Flash memory (text + data): 218276(+218276) bytes
+| main.cpp.obj            |     7528(+7528) |     92(+92) | 15694(+15694) |
+| Subtotals               | 214932(+214932) | 3408(+3408) | 35552(+35552) |
+Total Static RAM memory (data + bss): 38960(+38960) bytes
+Total Flash memory (text + data): 218340(+218340) bytes
 
Flash used: 237260 (11%) / total: 2097152
SRAM used: 39272 (7%) / total: 524288

@github-actions
Copy link

github-actions bot commented Dec 6, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 169972 (64%) 92172 (35%) 30928 (5%)
os 420920 (26%) 1143752 (73%) 80704 (15%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ❌ 420792 (20%)
420920 (20%)		 📈
128 (0%)		 80696 (15%)
80704 (15%)		 📈
8 (0%)
bootloader ✔️ ✅ ✅ 169972 (8%) ø 30928 (5%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 394076 (18%) ø 20456 (3%) ø
functional_ut_core_imu ✔️ ✅ ✅ 377068 (17%) ø 20432 (3%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ ✅ ✅ 360236 (17%) ø 20440 (3%) ø
functional_ut_deep_sleep_core_motor ✔️ ✅ ✅ 364476 (17%) ø 20480 (3%) ø
functional_ut_deep_sleep_core_pwm ✔️ ✅ ✅ 366612 (17%) ø 20480 (3%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 352504 (16%) ø 20408 (3%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 354216 (16%) ø 20408 (3%) ø
functional_ut_file_manager ✔️ ✅ ✅ 374536 (17%) ø 20696 (3%) ø
functional_ut_imu_kit ✔️ ✅ ✅ 382560 (18%) ø 20424 (3%) ø
functional_ut_io_expander ✔️ ✅ ✅ 359232 (17%) ø 20424 (3%) ø
functional_ut_qdac ✔️ ✅ ✅ 360400 (17%) ø 20424 (3%) ø
spike_lk_accel_gyro ✔️ ✅ ✅ 71184 (3%) ø 11808 (2%) ø
spike_lk_audio ✔️ ✅ ✅ 125076 (5%) ø 14568 (2%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 190200 (9%) ø 48144 (9%) ø
spike_lk_ble ✔️ ❌ ❌ 228960 (10%)
229024 (10%)		 📈
64 (0%)		 28320 (5%)
28328 (5%)		 📈
8 (0%)
spike_lk_bluetooth ✔️ ✅ ✅ 82948 (3%) ø 11544 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 145848 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65776 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 193048 (9%) ø 50968 (9%) ø
spike_lk_config_kit ✔️ ✅ ✅ 126956 (6%) ø 14312 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 80228 (3%) ø 12256 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74800 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 139016 (6%) ø 14416 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 327112 (15%) ø 27576 (5%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_fs ✔️ ✅ ✅ 174808 (8%) ø 47904 (9%) ø
spike_lk_imu_kit ✔️ ✅ ✅ 87700 (4%) ø 12176 (2%) ø
spike_lk_lcd ✔️ ✅ ✅ 162428 (7%) ø 46632 (8%) ø
spike_lk_led_kit ✔️ ✅ ✅ 103992 (4%) ø 14608 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 63288 (3%) ø 12256 (2%) ø
spike_lk_motion_kit ✔️ ✅ ✅ 100956 (4%) ø 14168 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62864 (2%) ø 11488 (2%) ø
spike_lk_qdac ✔️ ✅ ✅ 78628 (3%) ø 11816 (2%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 103480 (4%) ø 14608 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 78956 (3%) ø 11504 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 67048 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 114308 (5%) ø 14056 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 143188 (6%) ø 15552 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 80068 (3%) ø 13272 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 58032 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-12-08 14:14:38.121024385 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-12-08 14:14:38.485026078 +0000
@@ -1,49 +1,49 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       618(+618) |     18(+18) |     227(+227) |
+| [fill]                     |       654(+654) |     18(+18) |     227(+227) |
 | [lib]/ActivityKit.a        |   19586(+19586) |       0(+0) |         0(+0) |
-| [lib]/BLEKit.a             |     1368(+1368) |       0(+0) |         0(+0) |
+| [lib]/BLEKit.a             |     1436(+1436) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1830(+1830) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |         78(+78) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       176(+176) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         60(+60) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       556(+556) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     7954(+7954) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1432(+1432) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       822(+822) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a             |   19410(+19410) |       0(+0) |       10(+10) |
 | [lib]/RFIDKit.a            |     1054(+1054) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1544(+1544) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       596(+596) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       910(+910) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c.a                  |   49944(+49944) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a                |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 173368(+173368) |   773(+773) | 19647(+19647) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   10684(+10684) |     16(+16) |     204(+204) |
 | __/__                      |       108(+108) |       0(+0) |         0(+0) |
-| main.cpp.obj               |   71134(+71134) |   548(+548) | 25195(+25195) |
-| Subtotals                  | 377892(+377892) | 3944(+3944) | 76384(+76384) |
-Total Static RAM memory (data + bss): 80328(+80328) bytes
-Total Flash memory (text + data): 381836(+381836) bytes
+| main.cpp.obj               |   71158(+71158) |   548(+548) | 25203(+25203) |
+| Subtotals                  | 378020(+378020) | 3944(+3944) | 76392(+76392) |
+Total Static RAM memory (data + bss): 80336(+80336) bytes
+Total Flash memory (text + data): 381964(+381964) bytes
 
Flash used: 420920 (20%) / total: 2097152
SRAM used: 80704 (15%) / total: 524288
spike_lk_ble (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-12-08 14:14:47.101070439 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-12-08 14:14:47.345071894 +0000
@@ -1,18 +1,18 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       378(+378) |     15(+15) |       86(+86) |
-| [lib]/BLEKit.a          |     1368(+1368) |       0(+0) |         0(+0) |
+| [fill]                  |       354(+354) |     15(+15) |       86(+86) |
+| [lib]/BLEKit.a          |     1436(+1436) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       154(+154) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |     1436(+1436) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   42076(+42076) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7084(+7084) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 141468(+141468) |   709(+709) | 19323(+19323) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     9520(+9520) |     16(+16) |     204(+204) |
-| main.cpp.obj            |     4484(+4484) |     92(+92) |   4862(+4862) |
-| Subtotals               | 208196(+208196) | 3408(+3408) | 24600(+24600) |
-Total Static RAM memory (data + bss): 28008(+28008) bytes
-Total Flash memory (text + data): 211604(+211604) bytes
+| main.cpp.obj            |     4504(+4504) |     92(+92) |   4870(+4870) |
+| Subtotals               | 208260(+208260) | 3408(+3408) | 24608(+24608) |
+Total Static RAM memory (data + bss): 28016(+28016) bytes
+Total Flash memory (text + data): 211668(+211668) bytes
 
Flash used: 229024 (10%) / total: 2097152
SRAM used: 28328 (5%) / total: 524288

@YannLocatelli YannLocatelli force-pushed the yann/feature/ble/get-os-version-in-advertising-data branch from 1dbbd35 to 2aef9a3 Compare December 6, 2022 13:20
@YannLocatelli YannLocatelli marked this pull request as ready for review December 6, 2022 13:20
@codecov
Copy link

codecov bot commented Dec 6, 2022 •
edited
Loading

Codecov Report

Merging #1186 (ec8efb6) into develop (c8b1a9b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1186      +/-   ##
===========================================
+ Coverage    96.10%   96.11%   +0.01%     
===========================================
  Files          146      146              
  Lines         3544     3554      +10     
===========================================
+ Hits          3406     3416      +10     
  Misses         138      138
Impacted Files Coverage Δ
libs/BLEKit/include/AdvertisingData.h 100.00% <100.00%> (ø)
libs/RobotKit/include/RobotController.h 94.86% <100.00%> (+0.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@YannLocatelli
Copy link
Member Author

Visible with nRF Connect

@YannLocatelli YannLocatelli linked an issue Dec 7, 2022 that may be closed by this pull request
[Task] - BLEKit - Add os version in advertising data #1177
Closed
ladislas
ladislas approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

just a very small suggestion.

will this work with the current or next version of the app? the value will be visible without connection?

libs/RobotKit/include/RobotController.h Outdated Show resolved Hide resolved
HPezz
HPezz approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@HPezz HPezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YannLocatelli YannLocatelli force-pushed the yann/feature/ble/get-os-version-in-advertising-data branch from 2aef9a3 to 9e31f72 Compare December 7, 2022 15:28
@YannLocatelli YannLocatelli force-pushed the yann/feature/ble/get-os-version-in-advertising-data branch from 9e31f72 to ec8efb6 Compare December 8, 2022 13:57
@YannLocatelli
Copy link
Member Author

rebased

@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ladislas ladislas merged commit 1138a06 into develop Dec 9, 2022
@ladislas ladislas deleted the yann/feature/ble/get-os-version-in-advertising-data branch December 9, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas ladislas approved these changes

@HPezz HPezz HPezz approved these changes

Assignees

@YannLocatelli YannLocatelli

Labels
01 - type: task Something to do
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

[Task] - BLEKit - Add os version in advertising data
3 participants
@YannLocatelli @ladislas @HPezz