🚸 (emergency stop): Add minimal delay to use emergency stop #1192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HPezz
force-pushed
the
hugo/feature/Prevent-emergency-reboot-during-Setup-state
branch
from
75cf2fd
to
92e8e6c
Compare
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
ladislas
approved these changes
Dec 8, 2022
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
Codecov Report
@@ Coverage Diff @@
## develop #1192 +/- ##
========================================
Coverage 96.10% 96.10%
========================================
Files 146 146
Lines 3544 3544
========================================
Hits 3406 3406
Misses 138 138
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
HPezz
force-pushed
the
hugo/feature/Prevent-emergency-reboot-during-Setup-state
branch
from
92e8e6c
to
6349c7a
Compare
HPezz
force-pushed
the
hugo/feature/Prevent-emergency-reboot-during-Setup-state
branch
from
96ef6bb
to
ef2deb8
Compare
ladislas
force-pushed
the
hugo/feature/Prevent-emergency-reboot-during-Setup-state
branch
from
ef2deb8
to
715bd0b
Compare
ladislas
deleted the
hugo/feature/Prevent-emergency-reboot-during-Setup-state
branch
YannLocatelli
requested changes
Dec 12, 2022
Comment on lines
-164
to
+179
| auto minimal_delay_over = 1001ms; | ||
| auto minimal_delay_over = 1001s; |
There was a problem hiding this comment.
Why this change from ms to s ?
If you want a delay over 11s, it is just 11s or 11001ms
| @@ -345,7 +345,7 @@ class RobotController : public interface::RobotController | |||
| auto is_autonomous_mode = state_machine.is(system::robot::sm::state::autonomous_activities); | |||
| auto NOT_is_autonomous_mode = !is_autonomous_mode; | |||
|
|
|||
| if (card == MagicCard::emergency_stop) { | |||
| if (card == MagicCard::emergency_stop && rtos::Kernel::Clock::now() - kSystemStartupTimestamp > 10s) { | |||
There was a problem hiding this comment.
You don't want a parameter as the startup duration to be drown in the code, I suggest to set at the start of the method or set in member variables.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.