Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LKCoreBattery driver #183

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Add LKCoreBattery driver #183

merged 1 commit into from
Mar 30, 2021

Conversation

Kabroc
Copy link
Contributor

@Kabroc Kabroc commented Mar 17, 2021

Just took what have been done with the microphone and replace some names so it can work with the battery AnalogIn.

@Kabroc Kabroc added the 01 - type: task Something to do label Mar 17, 2021
@Kabroc Kabroc requested a review from ladislas March 17, 2021 16:03
@Kabroc Kabroc self-assigned this Mar 17, 2021
@Kabroc Kabroc added this to In progress in LekaOS - Tasks, Bugs & PRs via automation Mar 17, 2021
@ladislas ladislas force-pushed the develop branch 3 times, most recently from 6d132f6 to ad821b2 Compare March 18, 2021 14:40
ladislas
ladislas requested changes Mar 23, 2021
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

une première review :)

drivers/LKCoreBattery/source/LKCoreBattery.cpp Outdated Show resolved Hide resolved
libs/FileManager/include/FileManager.h Outdated Show resolved Hide resolved
spikes/lk_sensor_battery/main.cpp Outdated Show resolved Hide resolved
spikes/lk_sensor_battery/main.cpp Outdated Show resolved Hide resolved
spikes/lk_sensor_battery/main.cpp Outdated Show resolved Hide resolved
spikes/lk_sensor_battery/main.cpp Outdated Show resolved Hide resolved
spikes/lk_sensor_battery/main.cpp Outdated Show resolved Hide resolved
LekaOS - Tasks, Bugs & PRs automation moved this from In progress to Review needed Mar 23, 2021
@ladislas
Copy link
Member

faut que tu rebases sur develop, tous les checks ne sont pas run en l'état.

@Kabroc Kabroc force-pushed the benjamin/feature/battery branch 3 times, most recently from e15757a to 9d9d455 Compare March 25, 2021 10:23
ladislas
ladislas requested changes Mar 25, 2021
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quelques changements

libs/FileManager/source/FileManager.cpp Outdated Show resolved Hide resolved
spikes/lk_sensor_battery/main.cpp Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 25, 2021 •
edited
Loading

Codecov Report

Merging #183 (5426877) into develop (66c41a0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #183   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        18    +3     
  Lines          213       232   +19     
=========================================
+ Hits           213       232   +19
Impacted Files Coverage Δ
drivers/LKCoreBattery/include/LKCoreBattery.h 100.00% <100.00%> (ø)
drivers/LKCoreBattery/source/LKCoreBattery.cpp 100.00% <100.00%> (ø)
drivers/LKCoreBattery/tests/LKCoreBattery_test.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66c41a0...5426877. Read the comment docs.

ladislas
ladislas requested changes Mar 25, 2021
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nouvelle review :) on s'approche doucement ! lis bien tous les commentaires, j'ai bien expliqué, j'ai commencé les modifications mais j'ai pas tout fait, à toi de creuser.

n'hésite pas à prendre du recul, regarde les fonctions de loin, cherche les symétries ou l'absence de symétrie --> c'est mieux d'en avoir si c'est la même chose.

drivers/LKCoreBattery/CMakeLists.txt Outdated Show resolved Hide resolved
libs/FileManager/source/FileManager.cpp Show resolved Hide resolved
spikes/lk_sensor_battery/main.cpp Outdated Show resolved Hide resolved
spikes/lk_sensor_battery/main.cpp Outdated Show resolved Hide resolved
spikes/lk_sensor_battery/main.cpp Outdated Show resolved Hide resolved
spikes/lk_sensor_battery/main.cpp Outdated Show resolved Hide resolved
spikes/lk_sensor_battery/main.cpp Outdated Show resolved Hide resolved
spikes/lk_sensor_battery/main.cpp Outdated Show resolved Hide resolved
spikes/lk_sensor_battery/main.cpp Outdated Show resolved Hide resolved
spikes/lk_sensor_battery/main.cpp Outdated Show resolved Hide resolved
@ladislas ladislas force-pushed the benjamin/feature/battery branch 3 times, most recently from ba9115e to 9027b1f Compare March 28, 2021 21:52
@Kabroc @ladislas
✨ (drivers): Add LKCoreBattery driver & spike
5426877 
The spike is a test to mesure how much time it takes for the battery to completely discharge while running a standard behavioral program

Co-authored-by: Ladislas de Toldi <ladislas@detoldi.me>
@codeclimate
Copy link

codeclimate bot commented Mar 30, 2021

Code Climate has analyzed commit 5426877 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@ladislas ladislas merged commit 6d4b783 into develop Mar 30, 2021
LekaOS - Tasks, Bugs & PRs automation moved this from Review needed to Done Mar 30, 2021
@ladislas ladislas deleted the benjamin/feature/battery branch March 30, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

@ladislas ladislas ladislas requested changes

Assignees

@Kabroc Kabroc

Labels
01 - type: task Something to do
Projects
No open projects
LekaOS - Tasks, Bugs & PRs
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kabroc @ladislas