Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define BLE pins in mbed_app.json (#74) #75

Closed
wants to merge 1 commit into from

Conversation

ladislas
Copy link
Member

The goal of this PR is to define the BlueNRG pins in mbed_app.json using the Leka defined names instead of the raw values.

This needs preceding PR to have Leka defined pins inside PinNames.h.

@ladislas ladislas self-assigned this Oct 10, 2020
@ladislas ladislas added this to In progress in LekaOS - Tasks, Bugs & PRs via automation Oct 10, 2020
@ladislas ladislas linked an issue Oct 10, 2020 that may be closed by this pull request
@ladislas ladislas marked this pull request as ready for review October 11, 2020 20:56
@ladislas
Copy link
Member Author

ladislas commented Oct 11, 2020

@YannLocatelli prenant l'exemple de BlueNRG, il faut définir les pins dans le mbed_app.json.

Mais je veux éviter qu'on mette les "raw values" (eg. PA_12) directement, il faut utiliser les pins définis par Leka.

J'ai donc dans un premier temps modifier le script de génération des pins pour les mettre directement dans PinNames.h (#76) et j'ai ensuite modifié les déclarations dans mbed_app.json.

Peux tu tester que ça marche sur le robot ?

avec git flow:

git flow feature pull origin 74-set-bluenrg-pins
make config && make

@YannLocatelli
Copy link
Member

YannLocatelli commented Oct 12, 2020

Ca fonctionne!

Par contre j'ai dû modifier le main.cpp du spike lk_ble puisque le BLE ne fonctionnait pas (pas d'adresse MAC donné, ni visible).
J'ai juste ajouté le fonctionnement dans un thread à part comme dans le cas de l'investigation day:

Thread thread_ble_event_queue;

[...]

thread_ble_event_queue.start(callback(&event_queue, &EventQueue::dispatch_forever));

LekaOS - Tasks, Bugs & PRs automation moved this from Review needed to Review approved Oct 12, 2020
@ladislas ladislas closed this Oct 12, 2020
@ladislas ladislas deleted the feature/74-set-bluenrg-pins branch October 12, 2020 13:45
LekaOS - Tasks, Bugs & PRs automation moved this from Review approved to Done Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
01 - type: task Something to do
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Task] - Configure BlueNRG with LekaPinNames values
2 participants