Motors Test Program #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannLocatelli
added
the
01 - type: story
ladislas
requested changes
Oct 20, 2020
There was a problem hiding this comment.
Merci pour la PR! Plein de bonnes idées, c'est cool! :)
J'ai fait quelques retours sur les termes utilisés afin de préciser un peu les concepts.
Bon boulot @YannLocatelli ! :)
github-actions
bot
added
99 - status: review needed
and removed
99 - status: in progress
labels
Closed
20 tasks
ladislas
added
01 - type: task
ladislas
reviewed
Oct 22, 2020
ladislas
reviewed
Oct 22, 2020
Comment on lines
11
to
17
| DigitalOut motor_right_dir_1(PE_4); | ||
| DigitalOut motor_right_dir_2(PE_5); | ||
| PwmOut motor_right_speed(PA_2); | ||
|
|
||
| DigitalOut motor_left_dir_1(PC_13); | ||
| DigitalOut motor_left_dir_2(PI_8); | ||
| PwmOut motor_left_speed(PA_1); |
There was a problem hiding this comment.
peut être utiliser les noms définis par PinNames.h
There was a problem hiding this comment.
Par contre pour avoir le même comportement, les directions des moteurs de gauches ont été inversés:
DigitalOut motor_left_dir_1(MOTOR_LEFT_DIRECTION_2);
DigitalOut motor_left_dir_2(MOTOR_LEFT_DIRECTION_1);L'inversion remonte au tableau en ligne Leka-MCU_Pins.gsheet
ladislas
approved these changes
Oct 22, 2020
github-actions
bot
added
99 - status: review approved
and removed
99 - status: review needed
labels
* Two motors lib * Add brake feature in one motor * Add test to choose motor * Add SD in prevision, for logs of measure of current for each motor
* Add 30s delay at beginning, ge time to close the robot * Same speed outside of test * Old program test verifying difference between stop and brake * Remove brake * Change translation to direction * Change translate to move * Change turn to rotation * Constrain speed by uint8_t and convert it to [0.0f, 1.0f]
ladislas
force-pushed
the
yann-motors-DOX
branch
from
b07a404
to
bfa176b
Compare
github-actions
bot
added
99 - status: done
and removed
99 - status: review approved
labels
ladislas
added a commit
that referenced
this pull request
Nov 25, 2020
Co-authored-by: Ladislas de Toldi <ladislas@detoldi.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Réalisation d'un programme de test pour essayer les différents moteurs (charbon et balais classiques) selon leurs rapports de réduction (1/20 et 1/30) et "pneus" (shore 60, 70 et 80).
Related story → #90