Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Identify correct class/method for query trace #153

Merged
merged 1 commit into from
Feb 8, 2024
Merged

FIX Identify correct class/method for query trace #153

merged 1 commit into from
Feb 8, 2024

Conversation

GuySartorelli
Copy link
Collaborator

@GuySartorelli GuySartorelli mentioned this pull request Feb 7, 2024
Closed
emteknetnz
emteknetnz suggested changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, looking at this pre-patch things looked very wrong

Just to confirm, are we expecting to have a large increase in the number of database calls being traced?

Before:
image

After:
image

@GuySartorelli
Copy link
Collaborator Author

Can't reproduce that - you may have done something different in one of those page loads, maybe?

emteknetnz
emteknetnz approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK it'll be something wrong with setup at my end

LGTM

@GuySartorelli
Copy link
Collaborator Author

This was approved by a core committer, so I'm self-merging.

@GuySartorelli GuySartorelli merged commit 9a590fa into lekoala:2.2 Feb 8, 2024
@GuySartorelli GuySartorelli deleted the pulls/2.2/fix-trace branch February 8, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GuySartorelli @emteknetnz