Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean command broken in master - works in 3.3.6 #1056

Closed
nixjdm opened this issue Aug 31, 2022 · 2 comments
Closed

clean command broken in master - works in 3.3.6 #1056

nixjdm opened this issue Aug 31, 2022 · 2 comments
Labels

Comments

@nixjdm
Copy link
Member

nixjdm commented Aug 31, 2022

Normally, clean would purge the build dir, now, it seems to not do anything. Even unreferenced artifacts I place in the build dir remain. This seems caused by recent changes from PR #203 in builder.py. @dairiki could you take a look?

prune(all=True), now returns an empty generator, instead of everything.

The test added in that PR is correct - in a lektor build, previously generated artifacts of sources that are now marked hidden to get pruned, but prune(all=True) fails.

@nixjdm nixjdm added the bug label Aug 31, 2022
@nixjdm
Copy link
Member Author

nixjdm commented Aug 31, 2022

Thanks!

@dairiki
Copy link
Contributor

dairiki commented Aug 31, 2022

Yup, my fault!

This issue is that this should be a yield from self.iter_existing_artifacts() rather than a return.

Thank you for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants