Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow widget collapse button triggers Data Unsaved Warning when moving away from edit page #828

Closed
arabidopsis opened this issue Nov 8, 2020 · 2 comments · Fixed by #842

Comments

@arabidopsis
Copy link
Contributor

When a flow collapse/expand button is clicked it marks the data as 'changed' so a triggers 'Prompt'.

Since no data has changed (only the ui layout) this is confusing. See the gif below.

I have a PR I can give you to fix this if you like.

Here is a simple project you can try yourself

Test1.zip

Visual:

flow

@runfalk
Copy link
Member

runfalk commented Nov 8, 2020

Hey @arabidopsis! We'd very much appreciate a PR for this. It's indeed confusing that collapsing marks the page as edited.

@arabidopsis
Copy link
Contributor Author

No problem... you might not like it though. I'm a bit stretched for time but I will make a PR soon. Also I
am a react novice... but there seems to be little out there about writing tests for React.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants