Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactNativeWeb BC fixed #121

Merged
merged 5 commits into from Nov 5, 2018
Merged

Conversation

tkow
Copy link
Contributor

@tkow tkow commented Sep 23, 2018

fix this issue
#120

Checking is available at this repository.
If at the repository you change dependency of react-primitives@<0.7.0, you can see error due to using styled-components/primitive.

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "react-primitives",
"version": "0.6.1",
"version": "0.7.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs shouldn’t bump version numbers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.I'm sorry and revert it.

@msand
Copy link
Contributor

msand commented Sep 24, 2018

Seems to work, lgtm

@tkow tkow changed the title [Fix] ReactNativeWeb BC fixed ReactNativeWeb BC fixed Oct 2, 2018
@geminiyellow
Copy link

good, rn4w 8.x is too old.

@kevinwolfcr
Copy link

Thanks! Any plans on releasing this soon?

@davidpett
Copy link
Contributor

running into this as well. this update of rnw will fix my issues too. are there any collaborators still active in this repo to merge and release? @mathieudutour is it just you now?

@geminiyellow
Copy link

looks no good. this repo have no enough collaborator.

@mathieudutour mathieudutour merged commit f6abf78 into lelandrichardson:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants