Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update character images to be consistent (300x300) #3

Closed
26 tasks done
lelouchB opened this issue Oct 5, 2020 · 5 comments · Fixed by #71
Closed
26 tasks done

Update character images to be consistent (300x300) #3

lelouchB opened this issue Oct 5, 2020 · 5 comments · Fixed by #71
Assignees
@SeguinLoic
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
v1.0.0

Comments

@lelouchB
Copy link
Owner

lelouchB commented Oct 5, 2020 •
edited
Loading

Currently the character images in ./backend/images folder are of different sizes.

Generate new images 300x300px jpg format.

  • Indicates that the 300x300px image exists for that character.

Here is the complete list of characters we need images for

  • Gary Goodspeed
  • Mooncake
  • Quinn Ergon
  • Little Cato
  • Avocato
  • KVN
  • Ash Graven
  • Fox
  • H.U.E
  • Clarence
  • Lord Commander
  • Nightfall
  • A.V.A
  • Tribore
  • John Goodspeed
  • Sheryl Goodspeed
  • Gary Goodspeed (Nightfall's timeline)
  • Bolo
  • Invictus
  • Melanie Dewinter
  • Harp Graven
  • Shannon Thunder
  • Chuck
  • Septim
  • Fraskenhaur
@lelouchB lelouchB added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 5, 2020
@lelouchB lelouchB added this to To do in v1.0.0 Oct 5, 2020
@lelouchB lelouchB pinned this issue Oct 5, 2020
@SeguinLoic
Copy link
Contributor

Hello !
Can i take this issue ? :)

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 5, 2020

Yes @SeguinLoic

I will assign this issue to you.

Let me know if you have any questions.

Which image are you planning of generating?

Thanks

@SeguinLoic
Copy link
Contributor

Thank you !
I think i'll generate all of them ;)

@lelouchB
Copy link
Owner Author

lelouchB commented Oct 5, 2020

@SeguinLoic
Thank you
That will be really helpful.

Just a suggestion, make sure the images you generate either by editing images on the web or taking screenshots during the episode, are close up of face and upper body.

Thanks 🙂

@lelouchB lelouchB moved this from To do to In progress in v1.0.0 Oct 5, 2020
@lelouchB lelouchB mentioned this issue Oct 6, 2020
Closed
25 tasks
@lelouchB lelouchB linked a pull request Oct 6, 2020 that will close this issue
Update character images #15
Closed
25 tasks
This was referenced Oct 6, 2020
Closed
Merged
@lelouchB lelouchB linked a pull request Oct 8, 2020 that will close this issue
Update character images #71
Merged
@lelouchB lelouchB moved this from In progress to Done in v1.0.0 Oct 8, 2020
@lelouchB lelouchB moved this from Done to Shipped to Production in v1.0.0 Oct 8, 2020
@lelouchB
Copy link
Owner Author

lelouchB commented Oct 8, 2020 •
edited
Loading

@SeguinLoic
I have shipped this to production
https://finalspaceapi.com/blog/avatar
Check it out here
https://finalspaceapi.com/api/v0/character

@lelouchB lelouchB unpinned this issue Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeguinLoic SeguinLoic

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
v1.0.0
Shipped to Production
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update character images
Update character images
2 participants
@SeguinLoic @lelouchB