Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflow): Create build frontend workflow #104

Merged
merged 1 commit into from
Oct 9, 2020
Merged

feat(workflow): Create build frontend workflow #104

merged 1 commit into from
Oct 9, 2020

Conversation

trybick
Copy link
Contributor

@trybick trybick commented Oct 8, 2020

Fixes #5

The workflow file was pretty standard - please let me know if you want to customize any of the options.

@lelouchB
Copy link
Owner

lelouchB commented Oct 9, 2020

@trybick
This is great, I will go ahead and merge this.

@lelouchB lelouchB merged commit 9364f9a into lelouchB:main Oct 9, 2020
@lelouchB
Copy link
Owner

lelouchB commented Oct 9, 2020

@trybick
There was a small issue with the workflow which I went ahead and fixed.

      - run: cd frontend
      - run: npm install
      - run: npm run build --if-present

Each step starts in the workspace directory or root directory so this will first cd into frontend and then for the second command i.e. npm install will run in the root directory and not frontend.

Here is the fix for this

      - run: |
              cd frontend
              npm install
              npm run build --if-present

This Stackoverflow Question explains it very well
https://stackoverflow.com/questions/59529042/difference-between-run-and-multiple-runs-in-github-actions

Also, Docusaurus requires version 10 and above
https://v2.docusaurus.io/docs/installation#requirements

So, I removed that also.

Thanks

@trybick
Copy link
Contributor Author

trybick commented Oct 9, 2020

@lelouchB Ah, thanks for fixing and explaining it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NodeJS CI Workflow
2 participants