Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added episode endpoint documentation #53

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Added episode endpoint documentation #53

merged 2 commits into from
Oct 8, 2020

Conversation

DmnChzl
Copy link
Contributor

@DmnChzl DmnChzl commented Oct 7, 2020

This is the /episode endpoint documentation 📚, following the issue #45

@lelouchB
Copy link
Owner

lelouchB commented Oct 7, 2020

Hey @mrdoomy
This looks great. Just a few little things.

Can you change this line

There are curently `23` episodes sorted by id, more are added every season. 

To something like this.

Currently there are 23 episodes spanning over two seasons released in 2018 and 2019. 
Season 1 premiered on TBS and consists of 10 episodes which are named as **Chapter 1**, **Chapter 2**, etc.

Season 2 premiered in 2019 on Adult Swim and consists of 13 episodes. 

Season 3 is currently in development and it's data will be added after it's release.

@DmnChzl
Copy link
Contributor Author

DmnChzl commented Oct 7, 2020

Hello again @lelouchB 👋
You're right! It's better now 🙂

@lelouchB
Copy link
Owner

lelouchB commented Oct 7, 2020

Great 💯

This issue is done, I will merge this as soon as #41 finishes and the episode endpoint becomes live.

Thanks for your work on this.

@lelouchB lelouchB merged commit 0b51c4a into lelouchB:main Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants