Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 404 Page #118

Closed
wants to merge 1 commit into from
Closed

Added 404 Page #118

wants to merge 1 commit into from

Conversation

Skr-suyash
Copy link
Contributor

@Skr-suyash Skr-suyash commented Oct 9, 2020

Added the 404 page.
Go to baseURL/404" to see it.
Check if it is working. 😄😅

@lelouchB
Copy link
Owner

lelouchB commented Oct 9, 2020

Added the 404 page.
Go to baseURL/404" to see it.
Check if it is working. 😄😅

You haven't checked?
Also what about other routes that doesn't exist?

@Skr-suyash
Copy link
Contributor Author

Skr-suyash commented Oct 9, 2020

Checked.
But the problem is that Docasaurus has no support for redirecting other routes to 404.
Should I use React Router.
Please check once yourself if it is working.
Only baseURL/404 is supported (in GitHub page)

@lelouchB
Copy link
Owner

lelouchB commented Oct 9, 2020 via email

@Skr-suyash
Copy link
Contributor Author

Hey, is this okay. 😁

@lelouchB
Copy link
Owner

Hey, is this okay. 😁

Still going through previous PRs, will get to this in a few hours.

Thanks for your patience

@lelouchB
Copy link
Owner

Hey @Skr-suyash
This looks great, I checked it
The problem is after npm run build, if we use npm run serve to serve the build folder, all the bad routes are automatically handled by Docusaurus
Here is the page for http://localhost:3000/5

image

But the same is not seen after the build folder is deployed with express.

This has become more for a investigation issue.
Thanks for your work

@lelouchB lelouchB closed this Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants