Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Descriptive Data for endpoint pings #77

Merged
merged 2 commits into from
Oct 8, 2020
Merged

Conversation

sno2
Copy link
Contributor

@sno2 sno2 commented Oct 8, 2020

Here is what my changes would make the / endpoint return:

[
  {
    "type": "GET",
    "name": "Endpoints Data",
    "path": "/",
    "fullUrl": "https://finalspaceapi.com/api/v0/"
  },
  {
    "type": "GET",
    "name": "All Characters",
    "path": "/character",
    "queryParams": [
      {
        "optional": true,
        "name": "Sort By",
        "values": [
          "asc",
          "desc"
        ]
      }
    ],
    "fullUrl": "https://finalspaceapi.com/api/v0/character"
  },
  {
    "type": "GET",
    "name": "Single Character",
    "path": "/character/<id>",
    "fullUrl": "https://finalspaceapi.com/api/v0/character/<id>"
  },
  {
    "type": "GET",
    "name": "All Episodes",
    "path": "/episode",
    "queryParams": [
      {
        "optional": true,
        "name": "Sort By",
        "values": [
          "asc",
          "desc"
        ]
      }
    ],
    "fullUrl": "https://finalspaceapi.com/api/v0/episode"
  },
  {
    "type": "GET",
    "name": "Single Episode",
    "path": "/episode/<id>",
    "fullUrl": "https://finalspaceapi.com/api/v0/episode/<id>"
  }
]

@sno2
Copy link
Contributor Author

sno2 commented Oct 8, 2020

#78 is the issue I created for this.

@lelouchB lelouchB linked an issue Oct 8, 2020 that may be closed by this pull request
@lelouchB
Copy link
Owner

lelouchB commented Oct 8, 2020

@CodingCarter
This is awesome, thank you so much for this 👍
Really appreciate it

@lelouchB lelouchB merged commit c416ac2 into lelouchB:main Oct 8, 2020
@sno2
Copy link
Contributor Author

sno2 commented Oct 8, 2020

@CodingCarter
This is awesome, thank you so much for this 👍
Really appreciate it

No problem! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Endpoint Creation optimization
2 participants