Fix unintended undef-hook invocation due to more than twice key lookup #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukamachi
force-pushed
the
fix/keymap-duplicates
branch
from
258a144
to
ee128fa
Compare
fukamachi
force-pushed
the
fix/keymap-duplicates
branch
from
ee128fa
to
314539b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the merge of #1004, the completion-mode can't use
C-nandC-pto choose an item.This is because #1004 adds minor-mode keymaps to the top of the keymaps list to make them a high priority. I didn't think this caused any problems, but it invoked the undef-hook of the completion keymap by accident.
The key command will go through the list of keymaps like this:
next-line->completion-next-line->completion-self-insert(by undef-hook).Reported by @Sasanidas.