Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project-switch issue when It doesn't exists projects #1053

Merged
merged 2 commits into from Sep 3, 2023

Conversation

altmoket
Copy link

@altmoket altmoket commented Sep 3, 2023

Hi there
The prompt-for-project method returns (show-message "No projects." :timeout 5) if there aren't any candidates.
I think the show-message function doesn't return nil and and that's why project-switch method fails.
This is the error message:

The value
  #<LEM/POPUP-WINDOW::POPUP-WINDOW {1004B65343}>
is not of type
  (OR STRING PATHNAME SYNONYM-STREAM FILE-STREAM NULL)
when binding :DEFAULTS
Backtrace for: #<SB-THREAD:THREAD "editor" RUNNING {100401DA73}>
0: (MAKE-PATHNAME :HOST NIL :DEVICE NIL :DIRECTORY NIL :NAME NIL :TYPE NIL :VERSION NIL :DEFAULTS #<LEM/POPUP-WINDOW::POPUP-WINDOW {1004B65343}> :CASE :LOCAL)
1: (UIOP/FILESYSTEM:CALL-WITH-CURRENT-DIRECTORY #<LEM/POPUP-WINDOW::POPUP-WINDOW {1004B65343}> #<FUNCTION (LAMBDA NIL :IN LEM-CORE/COMMANDS/PROJECT::PROJECT-SWITCH) {52C7FE7B}>)
2: (LEM-CORE:CALL-COMMAND LEM-CORE/COMMANDS/PROJECT::PROJECT-SWITCH NIL)
3: (LEM-CORE::COMMAND-LOOP-BODY)
4: (LEM-CORE:COMMAND-LOOP)
5: (LEM-CORE::TOPLEVEL-COMMAND-LOOP #<FUNCTION (LAMBDA NIL :IN LEM-CORE::RUN-EDITOR-THREAD) {1004B5BB4B}>)
6: ((LAMBDA NIL :IN LEM-CORE::RUN-EDITOR-THREAD))
7: ((LAMBDA NIL :IN LEM-CORE::RUN-EDITOR-THREAD))
8: ((LABELS BORDEAUX-THREADS::%BINDING-DEFAULT-SPECIALS-WRAPPER :IN BORDEAUX-THREADS::BINDING-DEFAULT-SPECIALS))
9: ((FLET SB-UNIX::BODY :IN SB-THREAD::RUN))
10: ((FLET "WITHOUT-INTERRUPTS-BODY-173" :IN SB-THREAD::RUN))
11: ((FLET SB-UNIX::BODY :IN SB-THREAD::RUN))
12: ((FLET "WITHOUT-INTERRUPTS-BODY-166" :IN SB-THREAD::RUN))
13: (SB-THREAD::RUN)
14: ("foreign function: call_into_lisp_")
15: ("foreign function: funcall1")

Copy link
Member

@cxxxr cxxxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.
I've commented, if you'd like to take a look.

src/commands/project.lisp Outdated Show resolved Hide resolved
@cxxxr cxxxr merged commit ad5bf64 into lem-project:main Sep 3, 2023
@cxxxr
Copy link
Member

cxxxr commented Sep 3, 2023

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants