Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: remove last of submodules #1105

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Conversation

seanfarley
Copy link
Collaborator

This pull request removes the last of the git submodules and turns lem into a single repo and back to being distributed :-)

We can justify this change because lem is just a consumer of language-server-protocol and not a distributor of it.

@cxxxr
Copy link
Member

cxxxr commented Sep 25, 2023

Indeed, this might be better.
What kind of operation is involved when bringing language-server-protocol up to date?

@seanfarley
Copy link
Collaborator Author

Indeed, this might be better.
What kind of operation is involved when bringing language-server-protocol up to date?

It's pretty much how you'd expect:

$ git rm -r language-server-protocol
$ cp -r /path/to/language-server-protocol-version language-server-protocol
$ git add language-server-protocol

Then commit with a message about which version you're updating to.

@cxxxr cxxxr merged commit 2d23897 into lem-project:main Sep 25, 2023
1 check passed
@cxxxr
Copy link
Member

cxxxr commented Sep 25, 2023

Hmm, still, please wait a moment.
The bundled stuff is so huge that, language-ratio-wise, this repository is no longer Common Lisp.

@cxxxr
Copy link
Member

cxxxr commented Sep 25, 2023

Rather than bundling large amounts of unnecessary code, it may be better to remove it and download it only when needed.

@seanfarley
Copy link
Collaborator Author

Oh yeah, that's fine too! I see you merged this already but I could try to write a makefile rule to update the directory as well.

@seanfarley seanfarley deleted the smf/vendor-lsp branch September 25, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants