Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export point accessors point-line and point-linum. #1204

Merged
merged 1 commit into from Dec 29, 2023

Conversation

mychris
Copy link
Contributor

@mychris mychris commented Dec 29, 2023

Small change which exports the two accessors point-line and point-linum.
There might be more functions which should be exported but I didn't go through the whole file.

@Sasanidas
Copy link
Member

LGTM!

@Sasanidas Sasanidas merged commit 97355fa into lem-project:main Dec 29, 2023
1 check passed
@cxxxr
Copy link
Member

cxxxr commented Dec 30, 2023

The line structure is an internal structure and should not be exported.
The point-linum is also an internal structure and should be exported using the function line-number-at-point instead.

@cxxxr
Copy link
Member

cxxxr commented Dec 30, 2023

Nevertheless, I appreciate your attempts to improve it.

@mychris
Copy link
Contributor Author

mychris commented Dec 30, 2023

Thanks for pointing me to the correct API. I couldn't find it, and since the API to get the point from the buffer is public, and all the other functions regarding point are public, I guessed those should be as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants