Fixes line-rendering for wrapping and scrolling. #1244
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next attempt to fix line rendering for #1243
The sdl2 front-end requires the whole line to be rendered. Otherwise, the caching of lines won't work. It also doesn't like empty strings.
The
left-side-width
depends on the front-end. For ncurses, it is the number of characters, for sdl2 the number of pixels.I also tried to fix the scrolling version with line-numbers. Because the line-numbers are appended before the calculations are done, those will be scrolled out as well.
Hopefully this works now.