Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VI-MODE] • Enhance define-vi-state to allow expose more of the defclass CLOS functionality. #700

Merged
merged 10 commits into from
Jun 10, 2023

Conversation

theangelperalta
Copy link
Contributor

@theangelperalta theangelperalta commented Jun 9, 2023

The plan is to use inheritance to reduce code redundancy and improve the extensibility of vi-states, such as visual state. Currently, visual state has three sub states (visual-char, visual-line, visual-block), which produce code redundancy with state changes.

TODO: Follow-up with PR to refactor redundancy visual state.

@theangelperalta theangelperalta marked this pull request as ready for review June 9, 2023 00:12
@theangelperalta
Copy link
Contributor Author

@cxxxr, this PR is ready for reviewing.

@cxxxr
Copy link
Member

cxxxr commented Jun 10, 2023

@theangelperalta
It's very good.
There is a behavior change in normal-mode and insert-mode where the cursor color is the same in both modes, is this intended?

@theangelperalta
Copy link
Contributor Author

theangelperalta commented Jun 10, 2023

@theangelperalta It's very good. There is a behavior change in normal-mode and insert-mode where the cursor color is the same in both modes, is this intended?

Nice catch @cxxxr, it I'll address the unintended behavioral change.

@cxxxr
Copy link
Member

cxxxr commented Jun 10, 2023

Thank you so much!
I think it is very good.

@cxxxr cxxxr merged commit 961b992 into lem-project:main Jun 10, 2023
1 check passed
@cxxxr cxxxr mentioned this pull request Jul 11, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants