Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: add left right button to #16

Closed
gardaholm opened this issue Jan 24, 2024 · 4 comments
Closed

feature request: add left right button to #16

gardaholm opened this issue Jan 24, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@gardaholm
Copy link
Contributor

really awesome repo, love it!

For the mobile view a left right button, next to the Climbs name would be really handy.
So you can scroll through the route-images easier.

image
@lemeryfertitta
Copy link
Owner

Great idea! I'll work on this in the next few days unless you're interested, in which case I am happy to accept PRs.

@gardaholm
Copy link
Contributor Author

would be great if you have time. left/right buttons would be really nice addition.

I played around a bit with another feature I had in mind: adding a username, fetching the ticked climbs and hiding them from the list. but I'm still having troubles with the api and can't fetch my own logbook :)

@lemeryfertitta
Copy link
Owner

lemeryfertitta commented Jan 26, 2024

@gardaholm prev/next buttons deployed! Check it out and let me know what you think. I think left/right swipe would be a nice addition, I'll branch that out to a separate issue.

adding a username, fetching the ticked climbs and hiding them from the list

You would need to add a password as well, getting the ticked climbs requires a login. There are two ways to do it - you can use the sync function, or the logbook API. Both should work. If we wanted to avoid storing user data (more expensive/complex), the logbook API would be the way to go. I think this is a much bigger ask though, as there would need to be some convenient way to "log in," and you'd have to log in separately for each type of board. I'm going to create a separate ticket for this request as well.

This kind of request points to a much bigger idea, which is just to fully replace these apps with an open source board app that can do everything for every board. I think thats a little ambitious for Climbdex at this point, but its something I've certainly thought about and do have some interest in working on.

@gardaholm
Copy link
Contributor Author

nice addition, this is really excellent to go through the results. love it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants