Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Climbs #64

Closed
2 tasks
p4t7m4n opened this issue May 2, 2024 · 4 comments
Closed
2 tasks

Share Climbs #64

p4t7m4n opened this issue May 2, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@p4t7m4n
Copy link

p4t7m4n commented May 2, 2024

I looked further into your great project and thought about some improvements. With my basic understanding I could try to implement them but I am not sure if it actually works.

  • It would be great to share climbs to other climbers at the same board (e.g. by adding a button to share the website to friends via NFC).
  • Also I think it would be nice to enable the functionallity of marking climbs as done.

Do you have anything planned in that direction?

@lemeryfertitta
Copy link
Owner

#46 covers marking climbs as done. You're welcome to take a crack at that, I already implemented the API calls in Boardlib but the UI work with Climbdex is still needed.

Sharing climbs more formally would be a nice feature. Maybe we need a separate "climb" page, as the climbs are only displayed as search results at the moment, so the only shareable link right now is a search result.

I've edited the title of this to focus on the sharing aspect as there is already an open issue for marking climbs done.

@lemeryfertitta lemeryfertitta changed the title Share climbs, Mark as done Share Climbs May 2, 2024
@lemeryfertitta lemeryfertitta added the enhancement New feature or request label May 2, 2024
@p4t7m4n
Copy link
Author

p4t7m4n commented May 2, 2024

Thanks for the quick reply. That sounds great!
If there is anything I could do/code, let me know.

@lemeryfertitta
Copy link
Owner

lemeryfertitta commented May 3, 2024

Thanks for the quick reply. That sounds great! If there is anything I could do/code, let me know.

You're absolutely welcome to work on any of the open and unassigned issues, including this one or #46 if you are interested. I think #46 is particularly valuable for making Climbdex a drop-in replacement for the existing apps, though it still requires some UI design considerations, which you are also welcome to help out with.

The README has a small guide on how to get started on development, but I'm also happy to answer any questions or improve that guide if anything is unclear.

@lemeryfertitta
Copy link
Owner

Going to close this issue, as #46 is complete and there is a new issue for tracking climb sharing with #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants