CSVExternalSort drops rows when using CSVFormat with .format option

[NTEREKAS]

ExternalSorting.zip

Attached a project demonstrating issue ....

[NTEREKAS]

why? csv supports newlines...how do you use double quotes and newlines in the file?

…

On Sun, Mar 19, 2023 at 2:31 PM Daniel Lemire ***@***.***> wrote: That's not a valid CSV input... "author","title" "Dan Simmons","Hyperion" "Dan Simmons","Hyperion" "Dan Simmons","Hyperion" "Dan Simmons","Hyperion" "Dan Simmons","Hyperion" "Dan Simmons","Hyperion" "Douglas Adams","The Hitchhiker's Guide to the Galaxy" "Douglas Adams","The Hitchhiker's Guide to the Galaxy" "Douglas Adams","The Hitchhiker's Guide to the Galaxy hello" "Douglas Adams","The Hitchhiker's Guide to the Galaxy" "Douglas Adams","The Hitchhiker's Guide to the Galaxy" "Douglas Adams","The Hitchhiker's Guide to the Galaxy" "Douglas Adams","The Hitchhiker's Guide to the Galaxy" "Dan ""The Man"" Simmons","Hyperion" — Reply to this email directly, view it on GitHub <#44 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQUKIE5SUHELOZSQJSJ2PE3W45GHXANCNFSM6AAAAAAV7Y3MZM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[lemire]

I thought it was invalid because of all the quotes. You are correct, it is valid.

[lemire]

I have added a test to the project corresponding to your use case.
See
#45

I am closing this issue, if you believe that there is a bug, please provide a reproducible test case. Ideally, you should provide a pull request.