Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding style scripts. #243

Merged
merged 5 commits into from
Aug 1, 2019
Merged

Adding style scripts. #243

merged 5 commits into from
Aug 1, 2019

Conversation

lemire
Copy link
Member

@lemire lemire commented Aug 1, 2019

This may help solve
#239

Importantly, we don't want clang-format to reorder the headers.

Otherwise, I am unable to find an automated way to reproduce the current code format which makes enforcing a style challenging. Any new clang-format call will affect all files.

Help needed.

cc @ioioioio

@ioioioio
Copy link
Member

ioioioio commented Aug 1, 2019

I found a project that claims to automatically test with clang-format that everything is fine. It seems to test only c++ files, and there is the possibility to exclude some files (the dependencies folder in our case).
https://github.com/Sarcasm/run-clang-format

However, I could not find how to test the ci configuration without commiting. I don't have a lot of experience with that.

@lemire
Copy link
Member Author

lemire commented Aug 1, 2019

@ioioioio Ok. I'll have a look. It is fine.

@lemire
Copy link
Member Author

lemire commented Aug 1, 2019

@ioioioio This looks good. This script should prove useful.

@lemire lemire merged commit 038b18e into master Aug 1, 2019
@lemire lemire deleted the stylecheck branch August 9, 2019 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants