I also added vertical scrolling and setup the controls as an option #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vertical Scrolling:
I first added dimensionData to hold the names of the functions and properties that are called to get dimension information.
I then added two helper functions
FuncandPropto help with passing/receiving information from the functions and properties while using the dynamic dimensionData.I then switched all references to use the two helper functions and the dimensionData object. A few of the animation objects had to be changed to create an object first, then set the property, and final then call the animation.
Controls Option:
I changed this to an option to give the user a little more flexibility.
Random Changes:
I fixed a few issues with creating variables twice. Not really a big issue, but my ide was giving me some grief.