Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow reusing a Reader object after close()/__exit__() #284

Closed
lemon24 opened this issue Jul 9, 2022 · 1 comment
Closed

Allow reusing a Reader object after close()/__exit__() #284

lemon24 opened this issue Jul 9, 2022 · 1 comment
Labels
API core

Comments

@lemon24
Copy link
Owner

lemon24 commented Jul 9, 2022

Because why not, especially when using as a context manager?

It doesn't really go against the main requirement in #206 (comment):

it should not be possible to (unknowingly) leak connections by using the same Reader object from multiple threads

For comparison, SQLAlchemy allows "reviving" an Engine as well.
@lemon24 lemon24 mentioned this issue Jul 13, 2022
Closed
@lemon24
Copy link
Owner Author

lemon24 commented Jul 16, 2022

Resolved in #206 / 05c1260.

@lemon24 lemon24 closed this as completed Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lemon24