Allow text nodes in diffing #30
Labels
enhancement
New feature or request
Projects
Comments
lemonadee71
added a commit
that referenced
this issue
Sep 20, 2022
The main change here is how we construct and create the template. This rewrite is to make the process involved more involved instead of having two different modes. Also, strings are now escaped by default. Diffing is also rewrote to include text nodes. This means that a way to differentiate must be created. We do this with the key property in __meta. One objective for this rewrite is to make future development easier and to allow flexibility for a possible plugin system. Closes #29 #30 #34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, to avoid complexity we need all elements under
is-listto have their text inside an element so we can just set theirinnerHTMLwhen the text changed. Related to #24 since if we allow that behavior, it should be acceptable in diffing too. One caveat is that this might require significant change in the way we approach diffing but refactor is due since I'd like to try optimizing it too. And fix #27 first before proceeding and make sure no there are no unnecessary renders.The text was updated successfully, but these errors were encountered: