Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some clips naming #155

Merged
merged 2 commits into from
Jul 23, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/cyan-peas-repeat.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@watching/cli': patch
'@watching/clips': patch
'@watching/clips-react': patch
---

Update some clips naming
92 changes: 43 additions & 49 deletions app/components/Clip/Clip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ import type {
} from '~/shared/clips';
import type {ArrayElement, ThenType} from '~/shared/types';

import clipsExtensionConfigurationQuery from './graphql/ClipExtensionConfigurationQuery.graphql';
import type {ClipExtensionConfigurationQueryData} from './graphql/ClipExtensionConfigurationQuery.graphql';
import updateClipsExtensionConfigurationMutation from './graphql/UpdateClipsExtensionConfigurationMutation.graphql';
import clipsExtensionSettingsQuery from './graphql/ClipExtensionSettingsQuery.graphql';
import type {ClipExtensionSettingsQueryData} from './graphql/ClipExtensionSettingsQuery.graphql';
import updateClipsExtensionSettingsMutation from './graphql/UpdateClipsExtensionSettingsMutation.graphql';
import type {InstalledClipExtensionFragmentData} from './graphql/InstalledClipExtensionFragment.graphql';
import uninstallClipsExtensionFromClipMutation from './graphql/UninstallClipsExtensionFromClipMutation.graphql';
import localClipQuery from './graphql/LocalClipQuery.graphql';
Expand All @@ -60,13 +60,10 @@ export interface Props<T extends ExtensionPoint> {
version: ClipsExtensionApiVersion;
script: string;
api: () => NoInfer<
Omit<
ApiForExtensionPoint<T>,
'extensionPoint' | 'version' | 'configuration'
>
Omit<ApiForExtensionPoint<T>, 'extensionPoint' | 'version' | 'settings'>
>;
build?: LocalClipQueryData.App.ClipsExtension.Build;
configuration?: GraphQlJSON;
settings?: GraphQlJSON;
}

type NoInfer<T> = T & {[K in keyof T]: T[K]};
Expand All @@ -81,7 +78,7 @@ export function InstalledClip<T extends ExtensionPoint>({
api,
extension,
version,
configuration,
settings,
extensionPoint,
}: InstalledClipExtensionFragmentData &
Pick<Props<T>, 'api' | 'extensionPoint'>) {
Expand All @@ -93,7 +90,7 @@ export function InstalledClip<T extends ExtensionPoint>({
name={extension.name}
version={version.apiVersion}
script={version.assets[0]!.source}
configuration={configuration ?? undefined}
settings={settings ?? undefined}
extensionPoint={extensionPoint}
/>
);
Expand Down Expand Up @@ -164,7 +161,7 @@ export function Clip<T extends ExtensionPoint>({
script,
build,
api,
configuration,
settings,
}: Props<T>) {
const controller = useMemo(
() => createController(COMPONENTS),
Expand All @@ -177,13 +174,11 @@ export function Clip<T extends ExtensionPoint>({
extensionPoint,
version: version as any,
script,
configuration,
settings,
});

useValueOnChange(configuration, () => {
sandboxController.internals.configuration.update(
JSON.parse(configuration ?? '{}'),
);
useValueOnChange(settings, () => {
sandboxController.internals.settings.update(JSON.parse(settings ?? '{}'));
});

return build ? (
Expand Down Expand Up @@ -245,7 +240,7 @@ function InstalledClipFrame<T extends ExtensionPoint>({
<ClipFrame
{...rest}
controller={controller}
renderPopoverContent={() => <InstalledClipConfiguration id={id} />}
renderPopoverContent={() => <InstalledClipSettings id={id} />}
renderPopoverActions={() => (
<>
<Button onPress={() => alert('App page not implemented yet!')}>
Expand All @@ -268,51 +263,50 @@ function InstalledClipFrame<T extends ExtensionPoint>({
);
}

function InstalledClipConfiguration({id}: {id: string}) {
const {data, isFetching} = useQuery(clipsExtensionConfigurationQuery, {
function InstalledClipSettings({id}: {id: string}) {
const {data, isFetching} = useQuery(clipsExtensionSettingsQuery, {
variables: {id},
});

if (data?.clipsInstallation == null) {
return (
<Text>
{isFetching ? 'Loading configuration...' : 'Something went wrong!'}
{isFetching ? 'Loading settings...' : 'Something went wrong!'}
</Text>
);
}

const {
clipsInstallation: {
configuration,
version: {translations, configurationSchema},
settings,
version: {translations, settings: schema},
},
} = data;

return (
<InstalledClipLoadedConfiguration
<InstalledClipLoadedSettings
id={id}
configuration={configuration}
settings={settings}
translations={translations}
configurationSchema={configurationSchema}
schema={schema}
/>
);
}

function InstalledClipLoadedConfiguration({
function InstalledClipLoadedSettings({
id,
configuration,
translations,
configurationSchema,
settings,
schema,
}: Pick<
ClipExtensionConfigurationQueryData.ClipsInstallation.Version,
'translations' | 'configurationSchema'
ClipExtensionSettingsQueryData.ClipsInstallation.Version,
'translations'
> &
Pick<
ClipExtensionConfigurationQueryData.ClipsInstallation,
'id' | 'configuration'
>) {
const updateClipsExtensionConfiguration = useMutation(
updateClipsExtensionConfigurationMutation,
Pick<ClipExtensionSettingsQueryData.ClipsInstallation, 'id' | 'settings'> & {
schema: ClipExtensionSettingsQueryData.ClipsInstallation.Version['settings'];
}) {
const updateClipsExtensionSettings = useMutation(
updateClipsExtensionSettingsMutation,
);

const [values, dispatch] = useReducer(
Expand All @@ -331,11 +325,11 @@ function InstalledClipLoadedConfiguration({

return state;
},
configuration,
(configuration) => {
const parsed = {...JSON.parse(configuration ?? '{}')};
settings,
(settings) => {
const parsed = {...JSON.parse(settings ?? '{}')};

return configurationSchema.reduce<Record<string, unknown>>(
return schema.fields.reduce<Record<string, unknown>>(
(normalized, field) =>
'key' in field
? {
Expand All @@ -352,13 +346,13 @@ function InstalledClipLoadedConfiguration({
const parsedTranslations = JSON.parse(translations ?? '{}');

return (
field: ClipExtensionConfigurationQueryData.ClipsInstallation.Version.ConfigurationSchema_ClipsExtensionNumberConfigurationField.Label,
field: ClipExtensionSettingsQueryData.ClipsInstallation.Version.Settings.Fields_ClipsExtensionSettingsStringField.Label,
) => {
switch (field.__typename) {
case 'ClipsExtensionConfigurationStringStatic': {
case 'ClipsExtensionSettingsStringStatic': {
return field.value;
}
case 'ClipsExtensionConfigurationStringTranslation': {
case 'ClipsExtensionSettingsStringTranslation': {
const translated = parsedTranslations[field.key];
if (translated == null) {
throw new Error(`No translation found for ${field.key}`);
Expand All @@ -373,9 +367,9 @@ function InstalledClipLoadedConfiguration({
}, [translations]);

const handleSubmit = () => {
updateClipsExtensionConfiguration.mutate({
updateClipsExtensionSettings.mutate({
id,
configuration: JSON.stringify(values),
settings: JSON.stringify(values),
});
};

Expand All @@ -391,9 +385,9 @@ function InstalledClipLoadedConfiguration({
return (
<Form onSubmit={handleSubmit}>
<BlockStack>
{configurationSchema.map((field) => {
{schema.fields.map((field) => {
switch (field.__typename) {
case 'ClipsExtensionStringConfigurationField': {
case 'ClipsExtensionSettingsStringField': {
return (
<TextField
key={field.key}
Expand All @@ -402,7 +396,7 @@ function InstalledClipLoadedConfiguration({
/>
);
}
case 'ClipsExtensionNumberConfigurationField': {
case 'ClipsExtensionSettingsNumberField': {
return (
<TextField
key={field.key}
Expand All @@ -411,7 +405,7 @@ function InstalledClipLoadedConfiguration({
/>
);
}
case 'ClipsExtensionOptionsConfigurationField': {
case 'ClipsExtensionSettingsOptionsField': {
return (
<Select
key={field.key}
Expand Down

This file was deleted.

49 changes: 49 additions & 0 deletions app/components/Clip/graphql/ClipExtensionSettingsQuery.graphql
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
query ClipExtensionSettings($id: ID!) {
clipsInstallation(id: $id) {
id
settings
version {
translations
settings {
fields {
... on ClipsExtensionSettingsStringField {
key
stringDefault: default
label {
...ClipsExtensionSettingsStringFragment
}
}
... on ClipsExtensionSettingsNumberField {
key
numberDefault: default
label {
...ClipsExtensionSettingsStringFragment
}
}
... on ClipsExtensionSettingsOptionsField {
key
optionsDefault: default
label {
...ClipsExtensionSettingsStringFragment
}
options {
value
label {
...ClipsExtensionSettingsStringFragment
}
}
}
}
}
}
}
}

fragment ClipsExtensionSettingsStringFragment on ClipsExtensionSettingsString {
... on ClipsExtensionSettingsStringStatic {
value
}
... on ClipsExtensionSettingsStringTranslation {
key
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
fragment InstalledClipExtension on ClipsExtensionInstallation {
id
extensionPoint
configuration
target
settings
version {
id
apiVersion
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
mutation UpdateClipsExtensionSettings($id: ID!, $settings: JSON) {
updateClipsExtensionInstallation(id: $id, settings: $settings) {
installation {
id
settings
}
}
}
2 changes: 1 addition & 1 deletion app/features/Apps/Apps.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function Apps() {
onPress={() => {
installExtension.mutate({
id: extension.id,
extensionPoint:
target:
extension.latestVersion?.supports[0]?.name,
});
}}
Expand Down
4 changes: 2 additions & 2 deletions app/features/Apps/graphql/AppsQuery.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ query Apps {
name
isInstalled
latestVersion {
supports {
name
extends {
target
}
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
mutation InstallClipsExtension($id: ID!, $extensionPoint: ClipsExtensionPoint) {
installClipsExtension(id: $id, extensionPoint: $extensionPoint) {
mutation InstallClipsExtension($id: ID!, $target: ClipsExtensionPoint) {
installClipsExtension(id: $id, target: $target) {
extension {
id
}
Expand Down
Loading