Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use temporary files to save dumps #88

Closed
Akarys42 opened this issue May 3, 2021 · 0 comments · Fixed by #98
Closed

Use temporary files to save dumps #88

Akarys42 opened this issue May 3, 2021 · 0 comments · Fixed by #98
Milestone

Comments

@Akarys42
Copy link
Contributor

Akarys42 commented May 3, 2021

Rationale

Currently dumps are saved under the home folder. If Blackbox unexpectedly exit during archiving, the file will be left there and not deleted. This can cause issues for both security and disk space.

Specification

tempfile.NamedTempFile can be used to pass a temporary file handle directly to the database handler and retrieved by the main function. This will also allow us to have uniform file names in a DRY fashion.

Note: I’d be interested in implementing that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants