Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for massCode manager #41

Merged
merged 3 commits into from Feb 23, 2022
Merged

Support for massCode manager #41

merged 3 commits into from Feb 23, 2022

Conversation

lemoony
Copy link
Owner

@lemoony lemoony commented Feb 20, 2022

No description provided.

@lemoony lemoony added the enhancement New feature or request label Feb 20, 2022
@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #41 (cf50e6a) into main (f588b2a) will increase coverage by 0.35%.
The diff coverage is 94.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   88.39%   88.75%   +0.35%     
==========================================
  Files          73       79       +6     
  Lines        3506     3698     +192     
==========================================
+ Hits         3099     3282     +183     
- Misses        302      307       +5     
- Partials      105      109       +4     
Flag Coverage Δ
Linux 88.45% <94.27%> (+0.37%) ⬆️
macOS 88.75% <94.27%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/config/service.go 80.14% <0.00%> (-1.81%) ⬇️
internal/utils/system/system.go 94.49% <60.00%> (-1.66%) ⬇️
internal/managers/masscode/parser_v1.go 91.83% <91.83%> (ø)
internal/managers/masscode/parser_v2.go 95.34% <95.34%> (ø)
internal/managers/masscode/config.go 100.00% <100.00%> (ø)
internal/managers/masscode/description.go 100.00% <100.00%> (ø)
internal/managers/masscode/manager.go 100.00% <100.00%> (ø)
internal/managers/masscode/model.go 100.00% <100.00%> (ø)
internal/config/create.go 96.36% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f588b2a...cf50e6a. Read the comment docs.

@lemoony lemoony marked this pull request as ready for review February 23, 2022 05:46
@lemoony lemoony merged commit d531597 into main Feb 23, 2022
@lemoony lemoony deleted the feature/masscode branch February 23, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant