Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompositeObserver.remove() returning Observer? #33

Closed
Robert-M-Muench opened this issue Jun 10, 2019 · 3 comments
Closed

CompositeObserver.remove() returning Observer? #33

Robert-M-Muench opened this issue Jun 10, 2019 · 3 comments

Comments

@Robert-M-Muench
Copy link

When I have:

CompositeObserver!E  myCO;

How am I supposed to remove an observer from it?

myCO = myCO.remove(observer);

doesn't work because of an implicit conversion error. Why isn't .remove() returning a CompositeObserver!E? If there is only one observer left, it could still be a CompositeObserver!E with just one element.

@lempiji
Copy link
Owner

lempiji commented Jun 14, 2019

There is a code flow that "remove one and return the rest when there are two remaining."
I think it is relatively advantageous in terms of performance because it reduces one layer of wrapping in the class. (Maybe I'm worrying too much.)

I think CompositeObserver should be Immutable in principle, so I'll add a function that returns CompositeObserver.

lempiji added a commit that referenced this issue Jun 14, 2019
@lempiji
Copy link
Owner

lempiji commented Jun 14, 2019

Please reopen if you have any concerns.

@lempiji lempiji closed this as completed Jun 14, 2019
@Robert-M-Muench
Copy link
Author

Robert-M-Muench commented Jun 15, 2019

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants