intrn(semester): improve the validation of creating a semester

routes/api/semester/create.post.ts

@@ -16,6 +16,7 @@ import string from "!/validators/base/string"
 import required from "!/validators/base/required"
 import oneOf from "!/validators/comparison/one-of"
 import length from "!/validators/comparison/length"
+import isLessThan from "!/validators/comparison/is_less_than"
 import makeResourceDocumentRules from "!/rule_sets/make_resource_document"
 
 export default class extends JSONController {
@@ -28,14 +29,19 @@ export default class extends JSONController {
 	}
 
 	makeBodyRuleGenerator(unusedAuthenticatedRequest: AuthenticatedRequest): FieldRules {
-		const attributes = {
+		const attributes: FieldRules = {
+			"endAt": {
+				"friendlyName": "end at",
+				"pipes": [ required, string, date ]
+			},
 			"name": {
 				"constraints": {
 					"length": {
 						"maximum": 255,
 						"minimum": 10
 					}
 				},
+				"friendlyName": "semester name",
 				"pipes": [ required, string, length ]
 			},
 			"semesterOrder": {
@@ -44,13 +50,17 @@ export default class extends JSONController {
 						"values": [ ...OrderValues ]
 					}
 				},
+				"friendlyName": "order",
 				"pipes": [ required, string, oneOf ]
 			},
 			"startAt": {
-				"pipes": [ required, string, date ]
-			},
-			"endAt": {
-				"pipes": [ required, string, date ]
+				"constraints": {
+					"isLessThan": {
+						"pointer": "data.attributes.endAt"
+					}
+				},
+				"friendlyName": "start at",
+				"pipes": [ required, string, date, isLessThan ]
 			}
 		}