unit(manager): ensure unattached users cannot be checked

lemredd · Sep 16, 2022 · 6350443 · 6350443
1 parent 35f938a
commit 6350443
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/database/managers/helpers/condition.ts b/database/managers/helpers/condition.ts
@@ -72,7 +72,7 @@ export default class Condition<T = any> {
 		return this
 	}
 
-	isIncludedIn(column: string, value: any[]): Condition {
+	isIncludedIn(column: string, value: any[]|Literal): Condition {
 		this.currentCondition[column] = { [Op.in]: value }
 		return this
 	}

diff --git a/database/managers/role.spec.ts b/database/managers/role.spec.ts
@@ -40,6 +40,17 @@ describe("Database Manager: Role read operations", () => {
 		expect(isTheOnlyRole).toBeFalsy()
 	})
 
+	it("cannot check for unattached user", async() => {
+		const manager = new Manager()
+		const model = await new Factory().insertOne()
+		const otherModel = await new Factory().insertOne()
+		await new UserFactory().attach(model).insertOne()
+
+		const isTheOnlyRole = await manager.isTheOnlyRoleToAnyUser(otherModel.id)
+
+		expect(isTheOnlyRole).toBeFalsy()
+	})
+
 	it("can count single model", async() => {
 		const manager = new Manager()
 		const model = await new Factory().insertOne()