Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls showing data from another repository? #1103

Closed
Hixie opened this issue Apr 9, 2018 · 14 comments
Closed

Coveralls showing data from another repository? #1103

Hixie opened this issue Apr 9, 2018 · 14 comments

Comments

@Hixie
Copy link

Hixie commented Apr 9, 2018

The source files listed on https://coveralls.io/github/flutter/flutter have nothing to do with our repo:

The coverage numbers seem accurate, though.

@thanosd
Copy link

thanosd commented Apr 12, 2018

I'm seeing the same thing. Commits from a totally different repo. Private repo:

https://coveralls.io/github/savvymx/savvyanalysis

@anjin
Copy link
Member

anjin commented Apr 12, 2018

Hi!

Make sure you have "service_name: travis-pro" in your .coveralls.yml.

Travis uses non-unique job id's between its free and pro services, so if Coveralls doesn't know that your service-name is travis-pro, it looks up the info for those job ids using the free Travis API -- that's why they will show random commits and builds. Once your ENV var is set to specify travis-pro, the correct info will be pulled from Travis's pro API.

Conversely, no one will be able to see your private commits because the Travis-pro API requires special authentication via your Github OAuth token (whereas Travis free doesn't require any) -- the build ID mix-up can only go one way thankfully.

@anjin anjin closed this as completed Apr 12, 2018
@thanosd
Copy link

thanosd commented Apr 12, 2018

Not so fast. ;) I already that have in my config and still seeing the issue.

@thanosd
Copy link

thanosd commented Apr 12, 2018

Related: shouldn't coveralls be "smart" enough to see this is a different repo and suppress the information?

Hixie added a commit to flutter/flutter that referenced this issue Apr 12, 2018
Hixie added a commit to flutter/flutter that referenced this issue Apr 25, 2018
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this issue May 14, 2018
@Hixie
Copy link
Author

Hixie commented May 18, 2018

I added the line suggested above, and it didn't fix it. If anything it made it worse, I'm not sure the numbers are correct anymore.

@Hixie
Copy link
Author

Hixie commented May 18, 2018

@anjin I think this should be reopened. It makes coveralls useless to us, basically.

@joroshiba joroshiba reopened this May 18, 2018
@joroshiba
Copy link
Collaborator

@Hixie, sorry for the inconvenience, we have identified the cause of this error and are working on getting a patch put together to solve it.

@Hixie
Copy link
Author

Hixie commented Jul 25, 2018

@bytewalls any news?

Hixie added a commit to flutter/flutter that referenced this issue Jul 25, 2018
This was added for lemurheavy/coveralls-public#1103 but that didn't help.
Hixie added a commit to flutter/flutter that referenced this issue Jul 30, 2018
This was added for lemurheavy/coveralls-public#1103 but that didn't help.
@Hixie
Copy link
Author

Hixie commented Nov 1, 2018

This is still broken. Flutter's coveralls page hasn't shown reasonable data since at least as far back as last April.

@Hixie
Copy link
Author

Hixie commented Jan 9, 2019

Since this continues to be broken I guess we'll have to stop trying to use coveralls.

@xster
Copy link

xster commented Jan 19, 2019

I think there are 2 separate issues.
https://coveralls.io/builds/21162782 etc are still showing the right per build data we're sending up to https://coveralls.io/api/v1/jobs. It's just not connecting to any metadata at the https://coveralls.io/github/flutter/flutter level.

Behind the scene, what data does coveralls retrieve from various CI's APIs based on service_name? Can we provide everything that coveralls needs in one single post to https://coveralls.io/api/v1/jobs and not depend on any callbacks to any CI service?

But otherwise, the fact that https://coveralls.io/github/flutter/flutter can't list the files in our repo at all seems like a bug since it shouldn't depend on any CIs to show the right data.

@stale
Copy link

stale bot commented Apr 20, 2020

This issue has been automatically marked for closure because it has not had recent activity. It will be closed if no further activity occurs. If your issue is still active please add a comment and we’ll review as soon as we can. Thank you for your contributions.

@Hixie
Copy link
Author

Hixie commented Apr 20, 2020

For what it's worth, we stopped using coveralls because of this issue.

@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked for closure because it has not had recent activity. It will be closed if no further activity occurs. If your issue is still active please add a comment and we’ll review as soon as we can. Thank you for your contributions.

@stale stale bot closed this as completed Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants