Add service_number to gitlab config defaults

lemurheavy · Mar 15, 2021 · 76b8fb8 · 76b8fb8
1 parent 7dff424
commit 76b8fb8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/lib/coveralls/configuration.rb b/lib/coveralls/configuration.rb
@@ -99,6 +99,7 @@ def self.set_service_params_for_tddium(config)
 
     def self.set_service_params_for_gitlab(config)
       config[:service_name]         = 'gitlab-ci'
+      config[:service_number]       = ENV['CI_PIPELINE_ID']
       config[:service_job_number]   = ENV['CI_BUILD_NAME']
       config[:service_job_id]       = ENV['CI_BUILD_ID']
       config[:service_branch]       = ENV['CI_BUILD_REF_NAME']

diff --git a/spec/coveralls/configuration_spec.rb b/spec/coveralls/configuration_spec.rb
@@ -224,9 +224,11 @@
     let(:service_job_number) { "spec:one" }
     let(:service_job_id) { 1234 }
     let(:service_branch) { "feature" }
+    let(:service_number) { 5678 }
 
     before do
       ENV.stub(:[]).with('CI_BUILD_NAME').and_return(service_job_number)
+      ENV.stub(:[]).with('CI_PIPELINE_ID').and_return(service_number)
       ENV.stub(:[]).with('CI_BUILD_ID').and_return(service_job_id)
       ENV.stub(:[]).with('CI_BUILD_REF_NAME').and_return(service_branch)
       ENV.stub(:[]).with('CI_BUILD_REF').and_return(commit_sha)
@@ -236,6 +238,7 @@
       config = {}
       Coveralls::Configuration.set_service_params_for_gitlab(config)
       config[:service_name].should eq('gitlab-ci')
+      config[:service_number].should eq(service_number)
       config[:service_job_number].should eq(service_job_number)
       config[:service_job_id].should eq(service_job_id)
       config[:service_branch].should eq(service_branch)