Lesson-20: functional programming #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitry-vs
approved these changes
Jun 12, 2022
| originalTeam: LeadOfTeam | ||
| ): LeadOfTeam => { | ||
| const obj = { ...originalTeam }; | ||
| obj.captain.age = 28; |
There was a problem hiding this comment.
Здесь происходит мутация внутреннего объекта (captain), как я понимаю. Потому что на 31 строке копирование поверхостное, не глубокое (то есть поле captain скопировалось в новый объект по ссылке, и указывает на поле captain из оригинального объекта).
Чтобы этого избежать, поле captain тоже нужно копировать:
export const originalTeamToExpectedTeamDeep = (originalTeam: Team): Team => {
const { captain } = originalTeam;
return { ...originalTeam, captain: { ...captain, age: 28 } };
};
There was a problem hiding this comment.
There was a problem hiding this comment.
Спасибо за комменты)
@AntiHero, jsdom: [Bug]: structuredClone is not defined #3363
jsdom/jsdom#3363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.