Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert TargetEventHandlers from class to function #12

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Conversation

lencioni
Copy link
Owner

The code added by Babel to compile this down to ES5 adds about 1.1 KiB
to the built version. We can pretty trivially avoid this for now by
using a function instead of a class. This drops the built filesize from
7.3 KiB to 6.2 KiB, which will be a small win for performance.

I think Babel 7 aims to make some changes that will help us use the
class syntax while avoiding this unnecessary overhead, at which point we
might want to re-evaluate this change. But for now, let's take the easy
bundle size win.

The code added by Babel to compile this down to ES5 adds about 1.1 KiB
to the built version. We can pretty trivially avoid this for now by
using a function instead of a class. This drops the built filesize from
7.3 KiB to 6.2 KiB, which will be a small win for performance.

I think Babel 7 aims to make some changes that will help us use the
class syntax while avoiding this unnecessary overhead, at which point we
might want to re-evaluate this change. But for now, let's take the easy
bundle size win.
@lencioni lencioni merged commit 3fa1bdb into master Jun 18, 2018
@lencioni lencioni deleted the removeclass branch June 18, 2018 16:34
lencioni added a commit to civiccc/react-waypoint that referenced this pull request Jun 18, 2018
None of the changes affect how consolidated-events is used in
react-waypoint.

Changelog:

- Now built with rollup ([#8](lencioni/consolidated-events#8))
- Deprecated `removeEventListener` export removed ([#13](lencioni/consolidated-events#13))
- Passive event listener test is now removed after being added ([#11](lencioni/consolidated-events#11))
- Reduced bundle size impact by replacing a class with a function ([#12](lencioni/consolidated-events#12))
lencioni added a commit to airbnb/react-outside-click-handler that referenced this pull request Jun 18, 2018
- Now built with rollup
  ([#8](lencioni/consolidated-events#8))
- Deprecated `removeEventListener` export removed
  ([#13](lencioni/consolidated-events#13))
- Passive event listener test is now removed after being added
  ([#11](lencioni/consolidated-events#11))
- Reduced bundle size impact by replacing a class with a function
  ([#12](lencioni/consolidated-events#12))
lencioni added a commit to react-dates/react-dates that referenced this pull request Jun 18, 2018
- Now built with rollup
  ([#8](lencioni/consolidated-events#8))
- Deprecated `removeEventListener` export removed
  ([#13](lencioni/consolidated-events#13))
- Passive event listener test is now removed after being added
  ([#11](lencioni/consolidated-events#11))
- Reduced bundle size impact by replacing a class with a function
  ([#12](lencioni/consolidated-events#12))
lencioni added a commit to react-dates/react-dates that referenced this pull request Jun 18, 2018
- Now built with rollup
  ([#8](lencioni/consolidated-events#8))
- Deprecated `removeEventListener` export removed
  ([#13](lencioni/consolidated-events#13))
- Passive event listener test is now removed after being added
  ([#11](lencioni/consolidated-events#11))
- Reduced bundle size impact by replacing a class with a function
  ([#12](lencioni/consolidated-events#12))
devs-cloud pushed a commit to devs-cloud/react-date that referenced this pull request Dec 27, 2019
- Now built with rollup
  ([#8](lencioni/consolidated-events#8))
- Deprecated `removeEventListener` export removed
  ([#13](lencioni/consolidated-events#13))
- Passive event listener test is now removed after being added
  ([#11](lencioni/consolidated-events#11))
- Reduced bundle size impact by replacing a class with a function
  ([#12](lencioni/consolidated-events#12))
MarcoAntonioAG pushed a commit to MarcoAntonioAG/React-dates that referenced this pull request Mar 31, 2022
- Now built with rollup
  ([#8](lencioni/consolidated-events#8))
- Deprecated `removeEventListener` export removed
  ([#13](lencioni/consolidated-events#13))
- Passive event listener test is now removed after being added
  ([#11](lencioni/consolidated-events#11))
- Reduced bundle size impact by replacing a class with a function
  ([#12](lencioni/consolidated-events#12))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant