Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review CmdChangeAttribute constructors #40

Closed
cecilios opened this issue Apr 25, 2016 · 1 comment
Closed

Review CmdChangeAttribute constructors #40

cecilios opened this issue Apr 25, 2016 · 1 comment

Comments

@cecilios
Copy link
Member

While documenting these commands some issues were raised and should be reviewed:

  • There is a group of constructors using an specific object as target. This object is passed in the constructor. Is this necessary?
    Instead, use the object pointed by the cursor?
  • There is another group of constructors without a target object. They seem to use as target the object pointed by the cursor.
    Is this necessary? Instead, use the objects in current selection?
  • Bool attributes are not considered, but LenMus used bool attributes and stores them in int variables. Is this correct?
    Define an specific constructor for bool values?
@cecilios
Copy link
Member Author

Closed. Time ago I used issues to track my TODO list. This is no longer the case and so I prefer to remove old issues I created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant